Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Bump grunt-lib-phantomjs to latest master #158

Merged
merged 1 commit into from
Mar 27, 2016
Merged

Bump grunt-lib-phantomjs to latest master #158

merged 1 commit into from
Mar 27, 2016

Conversation

BYK
Copy link
Collaborator

@BYK BYK commented Mar 26, 2016

Fixes #157.

With this patch, the project uses Phantom2 to run tests.

Uses the latest commit from grunt-lib-phantomjs instead of the latest published 1.0.1 version since it has a bug on Windows, causing random EBUSY errors which is fixed on master.

},
"dependencies": {
"grunt-lib-phantomjs": "^0.7.1",
"mocha": "^2.3.4",
"grunt-lib-phantomjs": "git+https://github.com/gruntjs/grunt-lib-phantomjs.git#776bc346a8b7e151fe55c7f6dcb5563c0272e51b",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the shorthand for this? gruntjs/grunt-lib-phantomjs.git#776bc346a8b7e151fe55c7f6dcb5563c0272e51b

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@kmiyashiro
Copy link
Owner

Nice, thanks a lot for fixing the XUnit reporter, I'll try testing soon.

With this patch, the project uses Phantom2 to run tests.
@BYK
Copy link
Collaborator Author

BYK commented Mar 26, 2016

@kmiyashiro updated to use shorter package path.

@kmiyashiro
Copy link
Owner

👍

@kmiyashiro kmiyashiro merged commit 6681bc1 into kmiyashiro:master Mar 27, 2016
@BYK BYK deleted the bump-phantom branch April 14, 2016 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump grunt-lib-phantomjs to ^1.0.0
2 participants