PCI: cpqphp: Remove unnecessary null test before debugfs_remove()

Fabian Frederick · bjorn-helgaas · commit 5d37818b9ccb · 2014-07-07T14:53:44.000-06:00
Fix checkpatch warning:
"WARNING: debugfs_remove(NULL) is safe this check is probably not required"

Signed-off-by: Fabian Frederick &lt;fabf@skynet.be&gt;
Signed-off-by: Bjorn Helgaas &lt;bhelgaas@google.com&gt;
CC: Ryan Desfosses &lt;ryan@desfo.org&gt;
diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
@@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
 
 void cpqhp_remove_debugfs_files(struct controller *ctrl)
 {
-	if (ctrl->dentry)
-		debugfs_remove(ctrl->dentry);
+	debugfs_remove(ctrl->dentry);
 	ctrl->dentry = NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)`
`216`	`216`
`217`	`217`	`void cpqhp_remove_debugfs_files(struct controller *ctrl)`
`218`	`218`	`{`
`219`		`- if (ctrl->dentry)`
`220`		`- debugfs_remove(ctrl->dentry);`
	`219`	`+ debugfs_remove(ctrl->dentry);`
`221`	`220`	`ctrl->dentry = NULL;`
`222`	`221`	`}`
`223`	`222`