Skip to content

Commit 976ef33

Browse files
ashokdeyashokdey
committedSep 10, 2022
up: eslint fixes, prettier integration and LF EOL
1 parent 08f7893 commit 976ef33

File tree

27 files changed

+202
-153
lines changed

27 files changed

+202
-153
lines changed
 

‎.editorconfig

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ root = true
33
[*]
44
indent_style = space
55
indent_size = 2
6-
76
end_of_line = lf
87
charset = utf-8
98
trim_trailing_whitespace = true

‎.eslintrc.json

+13-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
{
2+
"env": {
3+
"node": true,
4+
"jest": true
5+
},
26
"extends": ["airbnb", "prettier"],
37
"plugins": ["prettier"],
48
"rules": {
5-
"prettier/prettier": ["error"]
9+
"prettier/prettier": ["error"],
10+
"no-underscore-dangle": "off",
11+
"no-param-reassign": "off",
12+
"no-console": "warn",
13+
"consistent-return": "warn",
14+
"max-classes-per-file": "off",
15+
"no-bitwise": "warn",
16+
"no-restricted-syntax": "warn",
17+
"no-continue": "warn"
618
}
719
}

‎.gitattributes

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* text eol=crlf

‎.prettierrc.js

+1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ module.exports = {
55
printWidth: 120,
66
tabWidth: 2,
77
arrowParens: 'always',
8+
endOfLine: 'lf',
89
};

‎src/_Algorithms_/lru-cache/LRUCache.test.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@ describe('Algorithms: LRU Cache', () => {
2828
lruCache.set('key1', 'value1');
2929
lruCache.set('key2', 'value2');
3030

31-
expect(lruCache.list.head.next.data['key']).toEqual('key2');
32-
expect(lruCache.list.head.next.data['value']).toEqual('value2');
31+
expect(lruCache.list.head.next.data.key).toEqual('key2');
32+
expect(lruCache.list.head.next.data.value).toEqual('value2');
3333

3434
// The least recently used key is moved at the beginning of the list
3535
lruCache.get('key1');
36-
expect(lruCache.list.head.next.data['key']).toEqual('key1');
37-
expect(lruCache.list.head.next.data['value']).toEqual('value1');
36+
expect(lruCache.list.head.next.data.key).toEqual('key1');
37+
expect(lruCache.list.head.next.data.value).toEqual('value1');
3838
});
3939
});
4040

4141
describe('set(key, value)', () => {
4242
it('Should append each <key:value> pair to the beginning of list', () => {
4343
lruCache.set('foo', 'bar');
44-
expect(lruCache.list.head.next.data['key']).toEqual('foo');
45-
expect(lruCache.list.head.next.data['value']).toEqual('bar');
44+
expect(lruCache.list.head.next.data.key).toEqual('foo');
45+
expect(lruCache.list.head.next.data.value).toEqual('bar');
4646
});
4747

4848
it('Should update value if key already exists', () => {
@@ -59,14 +59,14 @@ describe('Algorithms: LRU Cache', () => {
5959
lruCache.set('key1', 'value1');
6060

6161
expect(lruCache.list.length()).toEqual(lruCache.size);
62-
expect(lruCache.list.head.next.data['key']).toEqual('key1');
63-
expect(lruCache.list.head.next.data['value']).toEqual('value1');
64-
expect(lruCache.list.head.next.next.data['key']).toEqual('key2');
65-
expect(lruCache.list.head.next.next.data['value']).toEqual('value2');
66-
expect(lruCache.list.head.next.next.next.data['key']).toEqual('key3');
67-
expect(lruCache.list.head.next.next.next.data['value']).toEqual('value3');
68-
expect(lruCache.list.head.next.next.next.next.data['key']).toEqual('key4');
69-
expect(lruCache.list.head.next.next.next.next.data['value']).toEqual('value4');
62+
expect(lruCache.list.head.next.data.key).toEqual('key1');
63+
expect(lruCache.list.head.next.data.value).toEqual('value1');
64+
expect(lruCache.list.head.next.next.data.key).toEqual('key2');
65+
expect(lruCache.list.head.next.next.data.value).toEqual('value2');
66+
expect(lruCache.list.head.next.next.next.data.key).toEqual('key3');
67+
expect(lruCache.list.head.next.next.next.data.value).toEqual('value3');
68+
expect(lruCache.list.head.next.next.next.next.data.key).toEqual('key4');
69+
expect(lruCache.list.head.next.next.next.next.data.value).toEqual('value4');
7070
});
7171
});
7272
});

‎src/_Algorithms_/path-finder/a-star/index.js

+8-10
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function AStar(s, e, row, col, inputGrid) {
1010
const start = s;
1111
const end = e;
1212

13-
function cell() {
13+
function Cell() {
1414
this.cellValue = null;
1515
this.parent_i = -1;
1616
this.parent_j = -1;
@@ -19,7 +19,7 @@ function AStar(s, e, row, col, inputGrid) {
1919
this.f = Number.MAX_SAFE_INTEGER;
2020
}
2121

22-
function pair(i, j, f) {
22+
function Pair(i, j, f) {
2323
this.i = i;
2424
this.j = j;
2525
this.f = f;
@@ -30,15 +30,13 @@ function AStar(s, e, row, col, inputGrid) {
3030
for (let i = 0; i < Row; i += 1) {
3131
grid[i] = [];
3232
for (let j = 0; j < Col; j += 1) {
33-
grid[i][j] = new cell();
33+
grid[i][j] = new Cell();
3434
grid[i][j].cellValue = inputGrid[i][j];
3535
}
3636
}
3737

3838
const isValid = (i, j) => i >= 0 && j >= 0 && i < Row && j < Col;
39-
4039
const isDestination = (i, j) => end.i === i && end.j === j;
41-
4240
const isBlocked = (i, j) => grid[i][j].cellValue === 0;
4341

4442
const euclideanDistance = (i, j) =>
@@ -64,7 +62,7 @@ function AStar(s, e, row, col, inputGrid) {
6462
}
6563
path.push([i, j]);
6664

67-
for (let i = 0; i < path.length; i += 1) {
65+
for (let z = 0; z < path.length; z += 1) {
6866
console.log(path[i]);
6967
}
7068
};
@@ -101,7 +99,7 @@ function AStar(s, e, row, col, inputGrid) {
10199
grid[i][j].h = h;
102100
grid[i][j].f = g + h;
103101

104-
const item = new pair(i, j, f);
102+
const item = new Pair(i, j, f);
105103
// can be improved by using Min-Heap DataStructure
106104
if (!openList.length) {
107105
openList.push(item);
@@ -123,8 +121,8 @@ function AStar(s, e, row, col, inputGrid) {
123121
return false;
124122
}
125123

126-
let i = start.i;
127-
let j = start.j;
124+
let { i } = start;
125+
let { j } = start;
128126
const openList = [];
129127
const openListMap = new Map();
130128
const closedListMap = new Map();
@@ -135,7 +133,7 @@ function AStar(s, e, row, col, inputGrid) {
135133
grid[i][j].g = 0;
136134
grid[i][j].f = 0;
137135

138-
openList.push(new pair(i, j, 0.0));
136+
openList.push(new Pair(i, j, 0.0));
139137

140138
openListMap[[i, j]] = 0;
141139

‎src/_Classics_/caeser_cipher/index.js

+39-31
Original file line numberDiff line numberDiff line change
@@ -18,44 +18,52 @@ function caesarCipher(str, num) {
1818
const alphabetsMap = new Map();
1919

2020
for (const index in alphabets) {
21-
alphabetsMap[alphabets[index]] = index;
21+
if (index) {
22+
alphabetsMap[alphabets[index]] = index;
23+
}
2224
}
2325

24-
for (let index in lowerCaseString) {
25-
// get the current character
26-
const currentCharacter = lowerCaseString[index];
26+
for (const index in lowerCaseString) {
27+
if (index) {
28+
// get the current character
29+
const currentCharacter = lowerCaseString[index];
2730

28-
// if character is space, add it to the result and continue to next
29-
if (currentCharacter === ' ') {
30-
result += currentCharacter;
31-
continue;
32-
}
31+
// if character is space, add it to the result and continue to next
32+
if (currentCharacter === ' ') {
33+
result += currentCharacter;
34+
continue;
35+
}
3336

34-
// determine the new index
35-
/**
36-
* const currentIndex = alphabets.indexOf(currentCharacter);
37-
*
38-
* With indexOf complexity will be O(n*26)
39-
* With Map complexity will be O(n).
40-
*/
41-
const currentIndex = Number(alphabetsMap[currentCharacter]);
42-
let newIndex = currentIndex + num;
43-
44-
// if the index passes 25, restart from 0
45-
if (newIndex > totalAlphabets - 1) {
46-
newIndex -= totalAlphabets;
47-
}
37+
// determine the new index
38+
/**
39+
* const currentIndex = alphabets.indexOf(currentCharacter);
40+
*
41+
* With indexOf complexity will be O(n*26)
42+
* With Map complexity will be O(n).
43+
*/
44+
const currentIndex = Number(alphabetsMap[currentCharacter]);
45+
let newIndex = currentIndex + num;
4846

49-
if (newIndex < 0) {
50-
newIndex = totalAlphabets + newIndex;
51-
}
47+
// if the index passes 25, restart from 0
48+
if (newIndex > totalAlphabets - 1) {
49+
newIndex -= totalAlphabets;
50+
}
51+
52+
if (newIndex < 0) {
53+
newIndex = totalAlphabets + newIndex;
54+
}
5255

53-
// check if the character in original string was upper case
54-
if (str[index] === str[index].toUpperCase()) {
55-
result += alphabets[newIndex].toUpperCase();
56-
} else {
57-
result += alphabets[newIndex];
56+
// check if the character in original string was upper case
57+
if (str[index] === str[index].toUpperCase()) {
58+
result += alphabets[newIndex].toUpperCase();
59+
} else {
60+
result += alphabets[newIndex];
61+
}
5862
}
5963
}
6064
return result;
6165
}
66+
67+
module.exports = {
68+
caesarCipher,
69+
};

‎src/_Classics_/fibonacci/index.js

+19-10
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
//The Fibonacci sequence: 0, 1, 1, 2, 3, 5, 8, 13, 21
1+
// The Fibonacci sequence: 0, 1, 1, 2, 3, 5, 8, 13, 21
22
// the algorithm has time complexity of O(n^2), very bad!
33
function fibonacci(position) {
44
// if position is 1 or 2, the number in fibonacci sequence will be 1
55
if (position === 1 || position === 0) {
66
return position;
7-
} else if (position < 0) {
7+
}
8+
if (position < 0) {
89
throw new Error('Invalid Position');
910
}
1011

@@ -27,15 +28,16 @@ function fibonacciMemoized(index, cache) {
2728

2829
if (cache[index]) {
2930
return cache[index];
31+
}
32+
if (index === 1 || index === 0) {
33+
return index;
34+
}
35+
if (index < 0) {
36+
throw new Error('Invalid Position');
3037
} else {
31-
if (index === 1 || index === 0) {
32-
return index;
33-
} else if (index < 0) {
34-
throw new Error('Invalid Position');
35-
} else {
36-
cache[index] = fibonacciMemoized(index - 1, cache) + fibonacciMemoized(index - 2, cache);
37-
}
38+
cache[index] = fibonacciMemoized(index - 1, cache) + fibonacciMemoized(index - 2, cache);
3839
}
40+
3941
return cache[index];
4042
}
4143

@@ -47,7 +49,8 @@ function fibonacciTabular(n) {
4749
const table = [0, 1];
4850
if (n === 1 || n === 0) {
4951
return n;
50-
} else if (n < 0) {
52+
}
53+
if (n < 0) {
5154
throw new Error('Invalid Position');
5255
}
5356
for (let i = 2; i <= n; i += 1) {
@@ -63,3 +66,9 @@ function fibonacciTabular(n) {
6366
// console.log('--');
6467
// console.log(`Fib memo - ${fibonacciMemoized(number)}`);
6568
// console.log(`Fib table - ${fibonacciTabular(number)}`);
69+
70+
module.exports = {
71+
fibonacci,
72+
fibonacciMemoized,
73+
fibonacciTabular,
74+
};

‎src/_DataStructures_/LinkedList/reverse-linked-list/reverse-linked-list.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('Reverse a LinkedList', () => {
1818
});
1919

2020
it('Should return `5`->`4`->`3`->`2`->`1` for the given list', () => {
21-
let reversedList = reverseLinkedList(list);
21+
const reversedList = reverseLinkedList(list);
2222
expect(reversedList.data).toEqual('5');
2323
expect(reversedList.next.data).toEqual('4');
2424
expect(reversedList.next.next.data).toEqual('3');
@@ -29,7 +29,7 @@ describe('Reverse a LinkedList', () => {
2929
it('Should return `3`->`2`->`1` after deleting 2 last nodes of the list', () => {
3030
list.removeFromEnd();
3131
list.removeFromEnd();
32-
let reversedList2 = reverseLinkedList(list);
32+
const reversedList2 = reverseLinkedList(list);
3333
expect(reversedList2.data).toEqual('3');
3434
expect(reversedList2.next.data).toEqual('2');
3535
expect(reversedList2.next.next.data).toEqual('1');

‎src/_DataStructures_/Stack/balanced-parenthesis/index.js

+12-11
Original file line numberDiff line numberDiff line change
@@ -13,34 +13,35 @@ Output: false
1313
const Stack = require('../index');
1414

1515
function checkBalancedParenthesis(expression) {
16-
let s = new Stack();
17-
for (let i = 0; i < expression.length; i++) {
16+
const s = new Stack();
17+
for (let i = 0; i < expression.length; i += 1) {
1818
const char = expression[i];
1919
if (char === '{' || char === '(' || char === '[') {
20-
//If current character is a starting bracket (‘(‘ or ‘{‘ or ‘[‘) then push it to stack
20+
// If current character is a starting bracket (‘(‘ or ‘{‘ or ‘[‘) then push it to stack
2121
s.push(char);
2222
} else {
2323
if (s.isEmpty()) {
24-
//when we have only right parenthesis or brackets in expresion
24+
// when we have only right parenthesis or brackets in expresion
2525
return false;
26-
} else if (
26+
}
27+
if (
2728
(char === '}' && s.peek() !== '{') ||
2829
(char === ')' && s.peek() !== '(') ||
2930
(char === ']' && s.peek() !== '[')
3031
) {
3132
return false;
3233
}
33-
//If the current character is a closing bracket (‘)’ or ‘}’ or ‘]’) then pop it from stack
34+
// If the current character is a closing bracket (‘)’ or ‘}’ or ‘]’) then pop it from stack
3435
s.pop();
3536
}
3637
}
3738
if (s.isEmpty()) {
38-
//expression has balanced parenthesis
39+
// expression has balanced parenthesis
3940
return true;
40-
} else {
41-
return false;
4241
}
42+
return false;
4343
}
4444

45-
console.log(checkBalancedParenthesis('{()}[]')); //true
46-
console.log(checkBalancedParenthesis('{()}}')); //false
45+
module.exports = {
46+
checkBalancedParenthesis,
47+
};

‎src/_DataStructures_/Stack/baseball-game/index.js

+4
Original file line numberDiff line numberDiff line change
@@ -100,3 +100,7 @@ The size of the input list will be between 1 and 1000.
100100
Every integer represented in the list will be between -30000 and 30000.
101101
102102
*/
103+
104+
module.exports = {
105+
sumOfPoints,
106+
};

‎src/_DataStructures_/Stack/remove-consecutive-repeated-digits/index.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,22 @@
77
const Stack = require('../index');
88

99
function removeConsecutiveDigits(no) {
10-
let s = new Stack();
10+
const s = new Stack();
1111
let newNo = '';
12-
//initally push first digit into stack
12+
// initally push first digit into stack
1313
newNo += no[0];
1414
s.push(no[0]);
15-
for (let i = 1; i < no.length; i++) {
15+
for (let i = 1; i < no.length; i += 1) {
1616
const digit = no[i];
17-
//if stack top and incoming digit is same ignore it else append to newNo.
17+
// if stack top and incoming digit is same ignore it else append to newNo.
1818
if (s.peek() !== digit) {
1919
newNo += digit;
2020
s.push(digit);
2121
}
2222
}
2323
return newNo;
2424
}
25+
26+
module.exports = {
27+
removeConsecutiveDigits,
28+
};

‎src/_DataStructures_/Stack/sort-a-stack/index.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,19 @@ const Stack = require('../index');
99
function sortStack(stack) {
1010
const tempStack = new Stack();
1111
while (!stack.isEmpty()) {
12-
//pop the first element from stack
13-
let temp = stack.pop();
14-
//for ascending order (tempStack.peek() < temp)
12+
// pop the first element from stack
13+
const temp = stack.pop();
14+
// for ascending order (tempStack.peek() < temp)
1515
while (!tempStack.isEmpty() && tempStack.peek() > temp) {
1616
stack.push(tempStack.pop());
1717
}
18-
//push the first element(temp) onto tempStack if tempStack.peek()<temp
18+
// push the first element(temp) onto tempStack if tempStack.peek()<temp
1919
tempStack.push(temp);
2020
}
2121
return tempStack;
2222
}
23+
24+
module.exports = sortStack;
2325
/*
2426
const s = new Stack();
2527

‎src/_DataStructures_/Trees/Trie/get-unique-words/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const Trie = require('../index');
21
const TrieNode = require('../Node');
32

43
function getAllUniqueWords(root, level, word) {

‎src/_PathFinder_/AStar/index.js

+20-16
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,31 @@ function AStar(s, e, row, col, inputGrid) {
2121
throw new Error('Error: Endpoint is unreachable');
2222
}
2323

24-
function cell() {
25-
this.cellValue = null;
26-
this.parent_i = -1;
27-
this.parent_j = -1;
28-
this.h = Number.MAX_SAFE_INTEGER;
29-
this.g = Number.MAX_SAFE_INTEGER;
30-
this.f = Number.MAX_SAFE_INTEGER;
24+
class Cell {
25+
constructor() {
26+
this.cellValue = null;
27+
this.parent_i = -1;
28+
this.parent_j = -1;
29+
this.h = Number.MAX_SAFE_INTEGER;
30+
this.g = Number.MAX_SAFE_INTEGER;
31+
this.f = Number.MAX_SAFE_INTEGER;
32+
}
3133
}
3234

33-
function pair(i, j, f) {
34-
this.i = i;
35-
this.j = j;
36-
this.f = f;
35+
class Pair {
36+
constructor(i, j, f) {
37+
this.i = i;
38+
this.j = j;
39+
this.f = f;
40+
}
3741
}
3842

3943
const grid = [];
4044

4145
for (let i = 0; i < Row; i += 1) {
4246
grid[i] = [];
4347
for (let j = 0; j < Col; j += 1) {
44-
grid[i][j] = new cell();
48+
grid[i][j] = new Cell();
4549
grid[i][j].cellValue = inputGrid[i][j];
4650
}
4751
}
@@ -105,7 +109,7 @@ function AStar(s, e, row, col, inputGrid) {
105109
grid[i][j].h = h;
106110
grid[i][j].f = g + h;
107111

108-
const item = new pair(i, j, f);
112+
const item = new Pair(i, j, f);
109113
// can be improved by using Min-Heap DataStructure
110114
if (!openList.length) {
111115
openList.push(item);
@@ -123,8 +127,8 @@ function AStar(s, e, row, col, inputGrid) {
123127
};
124128

125129
const search = () => {
126-
let i = start.i;
127-
let j = start.j;
130+
let { i } = start;
131+
let { j } = start;
128132
const openList = [];
129133
const openListMap = new Map();
130134
const closedListMap = new Map();
@@ -135,7 +139,7 @@ function AStar(s, e, row, col, inputGrid) {
135139
grid[i][j].g = 0;
136140
grid[i][j].f = 0;
137141

138-
openList.push(new pair(i, j, 0.0));
142+
openList.push(new Pair(i, j, 0.0));
139143

140144
openListMap[[i, j]] = 0;
141145

‎src/_Problems_/balanced-parentheses.test.js

+4-7
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,17 @@ const { parentheses } = require('.');
22

33
describe('Parentheses', () => {
44
it('Should return true only when matching brackets are there', () => {
5-
expect(parentheses("{[()]})").toEqual('Balanced');
5+
expect(parentheses('{[()]})').toEqual('Balanced'));
66
});
77

88
it('Should return false when matching brackets are not there', () => {
9-
expect(parentheses("{[()}])").toEqual('UnBalanced');
9+
expect(parentheses('{[()}])').toEqual('UnBalanced'));
1010
});
1111
it('Should return true only when matching brackets are there', () => {
12-
expect(parentheses("{()})").toEqual('Balanced');
12+
expect(parentheses('{()})').toEqual('Balanced'));
1313
});
1414

1515
it('Should return false when matching brackets are not there', () => {
16-
expect(parentheses("{[}])").toEqual('UnBalanced');
16+
expect(parentheses('{[}])').toEqual('UnBalanced'));
1717
});
18-
19-
20-
2118
});

‎src/_Problems_/factorial/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
function factorial(num) {
22
if (num === 1) return num;
3-
else return num * factorial(num - 1);
3+
return num * factorial(num - 1);
44
}
55

66
module.exports = {

‎src/_Problems_/find-2nd-max/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function findSecondMax(arr) {
88
let max = arr[0];
99
let max2 = Number.MIN_SAFE_INTEGER;
1010

11-
for (let el of arr) {
11+
for (const el of arr) {
1212
if (el > max) {
1313
max2 = max;
1414
max = el;

‎src/_Problems_/get-mazePath/index.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//======================================Problem Statement=============================================
1+
//= =====================================Problem Statement=============================================
22
// --->> Print all possible path to reach the end of the GRID/MAZE (N x N) from starting point to ending point
33
// --->> One horizontal move will be represented by H and one vertical move will be represented by V
44
// --->> Complexity = Complexity will be exponential as there are many overlapping solutions
@@ -8,29 +8,29 @@
88
// --->> ec = end column
99

1010
const getMazePath = (cr, cc, er, ec) => {
11-
if (cr == er && cc == ec) {
12-
//============POSITIVE BASE CASE===========
13-
let br = [];
11+
if (cr === er && cc === ec) {
12+
//= ===========POSITIVE BASE CASE===========
13+
const br = [];
1414
br.push('');
1515
return br;
1616
}
1717

1818
if (cr > er || cc > ec) {
19-
//============NEGATIVE BASE CASE===========
20-
let br = [];
19+
//= ===========NEGATIVE BASE CASE===========
20+
const br = [];
2121
return br;
2222
}
2323

24-
let myResult = [];
24+
const myResult = [];
2525

26-
let recResultH = getMazePath(cr, cc + 1, er, ec);
26+
const recResultH = getMazePath(cr, cc + 1, er, ec);
2727
recResultH.forEach((rrh) => {
28-
myResult.push('H' + rrh);
28+
myResult.push(`H${rrh}`);
2929
});
3030

31-
let recResultV = getMazePath(cr + 1, cc, er, ec);
31+
const recResultV = getMazePath(cr + 1, cc, er, ec);
3232
recResultV.forEach((rrv) => {
33-
myResult.push('V' + rrv);
33+
myResult.push(`V${rrv}`);
3434
});
3535

3636
return myResult;

‎src/_Problems_/get-string-permutations/index.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
// GET PERMUTATION OF A GIVEN STRING
22

33
const getPermutations = (str) => {
4-
let result = [];
4+
const result = [];
55

6-
if (str.length == 0) {
6+
if (str.length === 0) {
77
return result;
88
}
99

10-
if (str.length == 1) {
10+
if (str.length === 1) {
1111
result.push(str);
1212
return result;
1313
}
1414

15-
let currentCharacter = str.charAt(0);
16-
let restOfString = str.substring(1);
17-
let returnResult = getPermutations(restOfString);
15+
const currentCharacter = str.charAt(0);
16+
const restOfString = str.substring(1);
17+
const returnResult = getPermutations(restOfString);
1818

19-
for (j = 0; j < returnResult.length; j++) {
20-
for (i = 0; i <= returnResult[j].length; i++) {
21-
let value = returnResult[j].substring(0, i) + currentCharacter + returnResult[j].substring(i);
19+
for (let j = 0; j < returnResult.length; j += 1) {
20+
for (let i = 0; i <= returnResult[j].length; i += 1) {
21+
const value = returnResult[j].substring(0, i) + currentCharacter + returnResult[j].substring(i);
2222
result.push(value);
2323
}
2424
}

‎src/_Problems_/index.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
function parentheses(s) {
77
if (typeof s !== 'string' || s.length % 2 !== 0) return false;
88
let i = 0;
9-
let arr = [];
9+
const arr = [];
1010
while (i < s.length) {
1111
if (s[i] === '{' || s[i] === '(' || s[i] === '[') {
1212
arr.push(s[i]);
@@ -16,10 +16,10 @@ function parentheses(s) {
1616
arr.pop();
1717
} else if (s[i] === ']' && arr[arr.length - 1] === '[') {
1818
arr.pop();
19+
} else {
20+
return 'Unbalanced';
1921
}
20-
return 'Unbalanced';
21-
22-
i++;
22+
i += 1;
2323
}
2424
if (arr.length === 0) return 'Balanced';
2525
}

‎src/_Problems_/max-consecutive-1s/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
function findMaxConsecutive1s(arr) {
1010
let count = 0;
1111
let max = 0;
12-
const length = arr.length;
12+
const { length } = arr;
1313

1414
for (let i = 0; i < length; i += 1) {
1515
if (arr[i] === 1) {

‎src/_Problems_/max-product-of-3-numbers/index.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,12 @@ function maxProductof3NumbersII(arr) {
3434
throw new Error('Invalid Argument');
3535
}
3636

37-
let firstMax = (secondMax = thirdMax = Number.MIN_SAFE_INTEGER);
38-
let firstMin = (secondMin = Number.MAX_SAFE_INTEGER);
37+
let firstMax = Number.MIN_SAFE_INTEGER;
38+
let secondMax = Number.MIN_SAFE_INTEGER;
39+
let thirdMax = Number.MIN_SAFE_INTEGER;
40+
41+
let firstMin = Number.MAX_SAFE_INTEGER;
42+
let secondMin = Number.MAX_SAFE_INTEGER;
3943

4044
for (let i = 0; i < arr.length; i += 1) {
4145
if (arr[i] > firstMax) {

‎src/_Problems_/product-of-elements/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function findProduct(arr) {
1313
const result = [];
1414

1515
// multiply all the numbers to the left side
16-
for (let el of arr) {
16+
for (const el of arr) {
1717
result.push(left);
1818
left *= el;
1919
}

‎src/_Problems_/reverse-number/index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ function reverseNumber(num) {
3737
For the purpose of this problem, assume that your function returns 0 when the reversed integer overflows.
3838
*/
3939

40-
function reverse32BitInt(x) {
40+
function reverse32BitInt(n) {
41+
let x = n;
4142
let isNegetive = 0;
4243
if (x < 0) {
4344
x *= -1;

‎src/_Problems_/rotate-image/index.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -53,29 +53,30 @@
5353
input matrix
5454
*/
5555

56-
function rotateImage(matrix) {
56+
function rotateImage(m) {
57+
const matrix = m;
5758
const n = matrix.length;
5859

5960
// take transpose
60-
for (let i = 0; i < n; i++) {
61-
for (let j = i; j < n; j++) {
61+
for (let i = 0; i < n; i += 1) {
62+
for (let j = i; j < n; j += 1) {
6263
const temp = matrix[i][j];
6364
matrix[i][j] = matrix[j][i];
6465
matrix[j][i] = temp;
6566
}
6667
}
6768

6869
// flip horizontally
69-
for (let i = 0; i < n; i++) {
70+
for (let i = 0; i < n; i += 1) {
7071
let left = 0;
7172
let right = n - 1;
7273

7374
while (left < right) {
7475
const temp = matrix[i][left];
7576
matrix[i][left] = matrix[i][right];
7677
matrix[i][right] = temp;
77-
left++;
78-
right--;
78+
left += 1;
79+
right -= 1;
7980
}
8081
}
8182
}

‎src/_Searching_/BinarySearch/index.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function binarySearch(arr, key) {
66
let high = arr.length - 1;
77

88
while (low <= high) {
9-
let mid = Math.floor((low + high) / 2);
9+
const mid = Math.floor((low + high) / 2);
1010

1111
if (key < arr[mid]) {
1212
high = mid - 1;
@@ -25,13 +25,17 @@ function binarySearchRecursive(arr, low, high, key) {
2525

2626
if (high <= low && arr[mid] !== key) {
2727
return null;
28-
} else if (key === arr[mid]) {
28+
}
29+
if (key === arr[mid]) {
2930
return mid;
30-
} else if (key < arr[mid]) {
31+
}
32+
if (key < arr[mid]) {
3133
return binarySearchRecursive(arr, low, mid - 1, key);
32-
} else if (key > arr[mid]) {
34+
}
35+
if (key > arr[mid]) {
3336
return binarySearchRecursive(arr, mid + 1, high, key);
3437
}
38+
return null;
3539
}
3640

3741
module.exports = {

0 commit comments

Comments
 (0)
Please sign in to comment.