Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SexpTaggedList.TryGetValue not implemented #38

Closed
atifaziz opened this issue Sep 9, 2015 · 1 comment
Closed

SexpTaggedList.TryGetValue not implemented #38

atifaziz opened this issue Sep 9, 2015 · 1 comment

Comments

@atifaziz
Copy link
Collaborator

atifaziz commented Sep 9, 2015

SexpTaggedList implements dictionary-like methods such as ContainsKey and key indexer but throws NotImplementedException for TryGetValue. For sake of consistency TryGetValue should be implemented.
atifaziz added a commit to atifaziz/RserveCLI2 that referenced this issue Sep 9, 2015
@atifaziz
SexpTaggedList.TryGetValue implementation (fixes konne#38)
24fae10
@atifaziz
Copy link
Collaborator Author

atifaziz commented Sep 9, 2015

Just to avoid confusion, please ignore 24fae10. Pulling on PR #39 will only bring in 0ddd665 that is a squash of 3 local commits post pushing 24fae10 to my fork.

SurajGupta added a commit that referenced this issue Sep 9, 2015
@SurajGupta
Merge pull request #39 from atifaziz/issue-38
d009c57 
SexpTaggedList.TryGetValue implementation (fixes #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atifaziz