Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidecar source selection for logs #2041

Closed
Adir111 opened this issue Dec 15, 2024 · 5 comments
Closed

Add sidecar source selection for logs #2041

Adir111 opened this issue Dec 15, 2024 · 5 comments
Assignees

Comments

@Adir111
Copy link
Contributor

Adir111 commented Dec 15, 2024

When viewing the logs of a job, we can choose a Source such as: Algorithm, System, or All. We need to add the sidecars of the job as well, if they exist. When sidecars are present, their names (which will appear as selection options in the drop-down list) can be found under the Algorithm in Details.sideCars.name.

image

NOTE - additional information can be found in a comment under this issue.

@Adir111
Copy link
Contributor Author

Adir111 commented Dec 15, 2024

Related to this issue: #1821

@Adir111
Copy link
Contributor Author

Adir111 commented Dec 22, 2024

Additional information regarding this issue:

  1. The names of the sideCar containers can be found in the algorithm.sideCars.name field within the Algorithm Details.

  2. Each sideCar contains the container name under the algorithm.sideCars.container.name field.
    To fully implement this feature, we need to retrieve the container.name values into an array.
    When the UI fetches logs using the LogsByQuery query, we need to include this array in the query. The field for this array should be named sideCarNames.

  3. When sending the query to fetch the logs of a sideCar, ensure that the logMode field in the query is set to logModes.SIDECAR. Make sure to update the consts package to version 1.0.55 in order to support this change.

@Adir111
Copy link
Contributor Author

Adir111 commented Dec 26, 2024

UPDATE - the query field has been updated to containerNames instead of sideCarNames

@zivglik
Copy link
Contributor

zivglik commented Jan 13, 2025

need remove "SiteCar" befor name

@golanha
Copy link
Member

golanha commented Jan 20, 2025

UI: Order of logs, All should be last in drop sown.
Structure: side car name and side car container should be one field. and should be checked for duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants