Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reconcileNormal function to accept context from caller #2018

Open
carmal891 opened this issue Oct 21, 2024 · 1 comment
Open

Refactor reconcileNormal function to accept context from caller #2018

carmal891 opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@carmal891
Copy link
Contributor

carmal891 commented Oct 21, 2024

/kind bug
/area provider/ibmcloud

What steps did you take and what happened:
Refactor the existing reconcileNormal function to accept a context parameter from the caller.

  1. The new function signature should be:
    reconcileNormal(ctx context.Context, machineScope *scope.PowerVSMachineScope)

  2. Update logs to use contextual logging with appropriate verbosity level - https://cluster-api.sigs.k8s.io/developer/logging#contextual-logging

  3. All code sections where reconcileNormal is invoked must also be updated accordingly

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Oct 21, 2024
@carmal891
Copy link
Contributor Author

/assign

@mkumatag mkumatag added this to the Next milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants