Keep Floating IP when deleting bastion host

[anders-elastisys]

/kind feature

Describe the solution you'd like
I want to have the option (or as default behavior) to keep the floating IP of the bastion host when deleting it if it is specified in openstackcluster.spec.bastion.floatingIP. There were some discussions about keeping floating IPs in this issue, but this does not seem to be the case for bastions atm.

Anything else you would like to add:
I believe this is the part that would need to be changed.

[anders-elastisys]

I tried implementing a fix for this myself which can be seen here. The idea is that as long as a floatingIP is set in the bastion spec of the openstackcluster resource, that floatingIP should not be deleted. I have tested this in a cluster and it seems to work fine as deleting the bastion host will just release its floatingIP with this change, but this can probably be improved and require tests.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[anders-elastisys]

/remove-lifecycle stale