Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart - add value to enable or disable CRD installation #4850

Open
mhanc opened this issue Nov 5, 2024 · 1 comment · May be fixed by #4913
Open

helm chart - add value to enable or disable CRD installation #4850

mhanc opened this issue Nov 5, 2024 · 1 comment · May be fixed by #4913
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mhanc
Copy link

mhanc commented Nov 5, 2024

What would you like to be added: Add helm value to helm chart to enable or disable CRD installation.

Why is this needed: This would allow and simplify installing multiple instances of external-dns to one cluster. Also in multi-tenant clusters, where CRD installation is not allowed, this would be an great enabler. Default value should be enabled, to not introduce any breaking changes, while allowing an override to disable the installation.

@mhanc mhanc added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 5, 2024
@matusf matusf linked a pull request Dec 2, 2024 that will close this issue
@stevehipwell
Copy link
Contributor

TL;DR - Use Helm's native support for ignoring chart CRDs (CRDs in the crds dir) via the --skip-crds flag.

@mhanc that's not how Helm's support of CRDs work; you can't template a CRD in the crds folder, they're either in the chart or not. Also as a best practice Helm should be used with the --skip-crds flag as it will not mange the CRD lifecycle. Please check out #4322 for the context around the decision to include the CRD in the Helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants