Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/kernel-module-management
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: kubernetes-sigs/kernel-module-management
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-2.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 91 files changed
  • 5 contributors

Commits on Oct 18, 2023

  1. adapting Device Plugin status report in Module to v.2 (#608)

    This commits adds implementation of reporting device plugin status
    into the Module's status.
    The following fields are reported:
    1) number of targeted nodes ( based on selector field)
    2) number of desired podsto be run
    3) current number of the pods actually running
    yevgeny-shnaidman authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1b36d84 View commit details
    Browse the repository at this point in the history
  2. Update webhook validation for name+namespace length (#607) (#611)

    Currently webhook verifies that module's name + namespace length
    does not exceed 40 chars in case version is defined. This commit removes
    the version condition and always verifies that length
    yevgeny-shnaidman authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    49f8b97 View commit details
    Browse the repository at this point in the history
  3. Restructure Worker Pod secrets' volumes' names (#612)

    Since the name of the volumes and volume mounts that are configured
    for service-account pull-secrets are constructed from "pull-secret"
    and the actual pull-secret name, then it can result in names being more
    then 63 chars which will cause an error. This comment move the volumes
    names to be "pull-secret-hash(pull-secret-name)"
    yevgeny-shnaidman authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2def6aa View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Set the worker restart policy to OnFailure (#609) (#617)

    Try loading or unloading kernel modules until either:
    - the Module is deleted, or;
    - the Pod template has changed.
    
    emove the inProgress field of the NMC statuses.
    qbarrand authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7c3cab8 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. adapting Worker Pods status report in Module to v.2 (#619) (#621)

    This commits adds implementation of reporting worker pods status
    into the Module's status.
    The following fields are reported:
    1) number of targeted nodes ( based on selector field)
    2) number of desired nodes that kernel module should be deployed (based
       on NMCs configured)
    3) current number of the nodes that the kernel module is already
       deployed to ( based on NMC spec and status configs)
    yevgeny-shnaidman authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    da78a7b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    b7b89da View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Rename controller-manager to controller (#636)

    Because this changes the deployment name in the CSV, it should allow for
    OLM upgrades despite the change in label selectors.
    qbarrand committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7219b76 View commit details
    Browse the repository at this point in the history
  2. Revert some changes to kustomization.yaml (#637)

    Bump versions for some of our generators.
    qbarrand committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ccbc8bd View commit details
    Browse the repository at this point in the history
  3. Do not set createdAt manually in the CSV (#641) (#642)

    operator-sdk now sets that field for us.
    Make new environment variables for the signer and worker image names
    mandatory.
    qbarrand authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    19c0c72 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. [release-2.0] Add commits for v2.0.1 (#681)

    * Remove deprecated module ready labels on nodes (#668)
    
    This change removes 'kmm.node.kubernetes.io/<module>.ready' labels on
    all nodes, as it was deprecated in v1.1 and removed in v2.0.
    
    * Fix handling of unknown kernels (#670)
    
    Fix scheduling data generation for nodes that run an unconfigured
    kernel and do not have the kmod loaded yet.
    
    * Build / sign: handle all owner kinds (#673)
    
    Make the build / sign events reconciler handle any owner for jobs, not
    only Module.
    
    * Refactor worker to support different type of image to be mounted (#677)
    
    Currently worker only supports remote image mounting (from a repo).
    In the future we might want to support also mounting an image from
    a local tar file. This Pr lays a foundation for that. The basic idea
    is that all the code should stay the same, and only the image mounting
    implementation should change, as well as adding additional cobra
    commands. The sequence to add a new image mounter option is:
    1. Define a new cobra command and mount it under root command
    2. the PreRun command in the new command should initialize the worker
       with the new image mounter
    3. define a new load/unload cobra commands that should be exact replicas
       of the existing load/unload cobra command. The copy must be done due
       to the fact that in cobra a command cannot be a child of multiple
       commands
    Changes in the PR:
    1. kmod cobra command now initializes the worker. it will initiaze it
       with remote image mounter implementation. In case we need to add ad
       different mounter, we just define a different kmod cobra command and
       it will initialize the worker with the different image mounter
       implmentation
    2. Change ImagePuller interface to ImageMounter interface
    3. Move ImageMounter interface definition to a dedicated file
    4. Move the implementation of the RemoteImageMounter into the dedicated
       file
    5 update unit-tests
    
    * Fixing DevicePlugin upgrade from v1.x to v2.x (#679)
    
    In v1.x we had 2 type of Daemonsets: DevicePlugin and ModuleLoader,
    which could be distingished by the DaemonsetRole label
    In v2.x, there only 1 type of daemonset, DevicePlugin, so the
    DaemonsetRole labels was removed.
    During DevicePlugin reconciliation, reconcile get all the device plugin
    Ds based only on module name label, which means that in case there is a
    v1.1 ModuleLoader DS running it will also be chosen. Once reconciler
    tries to reconcile ModuleLoader DS, it will fail
    This PR, updates the function that chooses the DevicePlugin DS, by
    removing old ModuleLoader Ds based on Role label
    
    ---------
    
    Co-authored-by: Yevgeny Shnaidman <[email protected]>
    qbarrand and yevgeny-shnaidman authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    41bbe1a View commit details
    Browse the repository at this point in the history
  2. Extract links from kmod images (#651) (#682)

    Create links as is when extracting files to the worker Pod filesystem.
    qbarrand authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c97cc9a View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Add extra label for controllers to install at worker nodes (#685)

    Signed-off-by: Enrique Belarte Luque <[email protected]>
    Co-authored-by: Enrique Belarte Luque <[email protected]>
    Configuration menu
    Copy the full SHA
    07b7b29 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. s/RELATED_IMAGES_/RELATED_IMAGE_/ (#711)

    Co-authored-by: Quentin Barrand <[email protected]>
    k8s-infra-cherrypick-robot and qbarrand authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    515aa59 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Allow the Hub to patch pods (#721)

    This is required for the BuildSignEvents reconciler to remove the
    finalizer.
    
    Co-authored-by: Quentin Barrand <[email protected]>
    k8s-infra-cherrypick-robot and qbarrand authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a468303 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Bring v2.0.2 commits (#754)

    * Add a webhook for namespace deletion (#719)
    
    This commit makes KMM set the kmm.node.k8s.io/contains-modules label on
    all namespaces that contain at least one Module.
    It also adds a new webhook to the bundle and the corresponding handler
    in the manager.
    The new webhook rejects namespace deletions if the
    kmm.node.k8s.io/contains-modules label is present on the namespace.
    This avoids entering situations where the namespace is being deleted and
    KMM cannot create unloading Pods to honor Module deletion.
    
    * Restrict checks for image existence (#734)
    
    Before populating the NodeModulesConfig object, only check if built or
    signed image exist on the registry.
    Add a log message when the NodeModulesConfig is not populated for that
    reason.
    
    * Make slight changes to the CRDs (#736)
    
    Module: make moduleName an optional field.
    ManagedClusterModule: make spokeNamespace a required field.
    qbarrand authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    2b97c9e View commit details
    Browse the repository at this point in the history
Loading