Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(helm/v1-alpha) Add ignore flags when generating charts #4326

Open
damsien opened this issue Nov 15, 2024 · 0 comments
Open

(helm/v1-alpha) Add ignore flags when generating charts #4326

damsien opened this issue Nov 15, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@damsien
Copy link
Contributor

damsien commented Nov 15, 2024

What do you want to happen?

Motivated by this discussion.

Today, when we want to use the helm plugin, the values.yaml is scaffolled with many defaults settings that the develope may not want to have (promtheus, some samples CRs, ...).

Our proposal is to implement ignore- flags that could be used when generating the values.yaml. The flags could be the following:

  • ignore-samples
  • ignore-prometheus
  • ignore-networkPolicy
  • ignore-certmanager
  • ignore-webhook

How to implement it?

Here is my proposal:

  1. Add the flags here:

    type editSubcommand struct {
    config config.Config
    force bool
    }

  2. Add one function per flag in this file in order to not add the settings to the scaffold if the ignore flag is specified

Extra Labels

No response

@damsien damsien added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2024
@camilamacedo86 camilamacedo86 added this to the helm milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants