Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function "runPromote" is overly complex #1177

Open
H0llyW00dzZ opened this issue Jan 20, 2024 · 3 comments · May be fixed by #1343
Open

Function "runPromote" is overly complex #1177

H0llyW00dzZ opened this issue Jan 20, 2024 · 3 comments · May be fixed by #1343
Assignees
@varshith257
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@H0llyW00dzZ
Copy link

H0llyW00dzZ commented Jan 20, 2024 •
edited
Loading

This function is overly complex

image

Link: here

What would you like to be added:

It would be better to split it into smaller functions, as this is Go, not Python, and Go
encourages simpler, more readable code.

Why is this needed:

In Go when each function overly complex, for example is reached 15+ complexity, it can leading a bugs
so by minimalist overly complex, it more better and can reusable
@H0llyW00dzZ H0llyW00dzZ added area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 20, 2024
H0llyW00dzZ added a commit to H0llyW00dzZ/promo-tools that referenced this issue Jan 20, 2024
@H0llyW00dzZ
Update Comment
f3e8576 
- [+] chore(pr.go): update comment to reference issue kubernetes-sigs#1177 and clarify code readability concerns
@H0llyW00dzZ H0llyW00dzZ mentioned this issue Jan 20, 2024
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2024
@xmudrii
Copy link
Member

xmudrii commented Apr 19, 2024

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 19, 2024
@varshith257
Copy link

varshith257 commented Jun 2, 2024 •
edited
Loading

@xmudrii I'd like to work on this issue
/assign

@varshith257 varshith257 linked a pull request Jun 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varshith257 varshith257

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Function "runPromote" is overly complex varshith257/promo-tools
5 participants
@H0llyW00dzZ @xmudrii @k8s-ci-robot @k8s-triage-robot @varshith257