-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace multiple ResourceMeta implementations with a single type #11886
Labels
kind/improvement
Improvement on an existing feature
triage/accepted
The issue was reviewed and is complete enough to start working on it
Comments
lobkovilya
added
triage/pending
This issue will be looked at on the next triage meeting
kind/improvement
Improvement on an existing feature
labels
Oct 28, 2024
jakubdyszkiewicz
added
triage/accepted
The issue was reviewed and is complete enough to start working on it
and removed
triage/pending
This issue will be looked at on the next triage meeting
labels
Oct 28, 2024
github-actions
bot
added
the
triage/pending
This issue will be looked at on the next triage meeting
label
Oct 28, 2024
jakubdyszkiewicz
removed
the
triage/pending
This issue will be looked at on the next triage meeting
label
Oct 28, 2024
michaelbeaumont
added a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this issue
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/improvement
Improvement on an existing feature
triage/accepted
The issue was reviewed and is complete enough to start working on it
Description
We have 9 different implementations of meta spread across various packages and 1
ResourceMeta
interface in thecore
package. This has downsides:ResourceMeta
interface, seeGetDisplayName
,IsReferenced
,ResourceOrigin
Single ResourceMeta type in
core
will be enough. ResourceMeta clients in various packages can create their own interfaces if needed.When it comes to KubernetesMetaAdapter, we don't have to store the entire
v1.ObjectMeta
object. We need to store onlyannotations
andUID
(UID can be encoded tometa.version
like{.ResourceVersion}/{.UID}
):The text was updated successfully, but these errors were encountered: