Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshGateway should be able to select something that is not kuma.io/service #12041

Open
lahabana opened this issue Nov 14, 2024 · 0 comments
Open
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

We're trying to distance ourselves from kuma.io/service on the dataplane.
Currently for a gateway I do:

apiVersion: kuma.io/v1alpha1
kind: MeshGateway
mesh: default
metadata:
  name: edge-gateway
spec:
  conf:
    listeners:
    - port: 80
      protocol: HTTP
  selectors:
  - match:
      kuma.io/service: edge-gateway_kuma-demo_svc
---
apiVersion: kuma.io/v1alpha1
kind: MeshGatewayInstance
metadata:
  name: edge-gateway
  namespace: kuma-demo
spec:
  replicas: 1
  serviceType: LoadBalancer

This creates that dataplane:

apiVersion: kuma.io/v1alpha1
kind: Dataplane
mesh: default
metadata:
  annotations:
    kuma.io/display-name: edge-gateway-66bdc8cd87-j8gn9
  creationTimestamp: "2024-11-14T09:19:32Z"
  generation: 1
  labels:
    k8s.kuma.io/namespace: kuma-demo
    kuma.io/env: kubernetes
    kuma.io/mesh: default
    kuma.io/origin: zone
    kuma.io/zone: default
  name: edge-gateway-66bdc8cd87-j8gn9
  namespace: kuma-demo
  ownerReferences:
  - apiVersion: v1
    blockOwnerDeletion: true
    controller: true
    kind: Pod
    name: edge-gateway-66bdc8cd87-j8gn9
    uid: ba069337-b277-4190-b7eb-964a3002a820
  resourceVersion: "5623"
  uid: 1326e038-d0d0-4219-bb65-fec91c3142f9
spec:
  networking:
    address: 10.244.0.15
    gateway:
      tags:
        kuma.io/service: edge-gateway_kuma-demo_svc
        kuma.io/zone: default
      type: BUILTIN

Would it be worth having other kuma system tags on the gateway or more simply use labels?

Then I could do:

apiVersion: kuma.io/v1alpha1
kind: MeshGateway
mesh: default
metadata:
  name: edge-gateway
spec:
  conf:
    listeners:
    - port: 80
      protocol: HTTP
  selectors:
  - match:
      k8s.kuma.io/namespace: kuma-demo
     <aLABELThat'sMissing>
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Nov 14, 2024
@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants