Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace - with _ before hash in identifiers in xDS config #12147

Open
bartsmykla opened this issue Dec 2, 2024 · 1 comment
Open

Replace - with _ before hash in identifiers in xDS config #12147

bartsmykla opened this issue Dec 2, 2024 · 1 comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bartsmykla
Copy link
Contributor

bartsmykla commented Dec 2, 2024 •
edited
Loading

What happened?

xref: kumahq/kuma-gui#3237

We are currently using - as a separator in the identifiers for built-in gateway in xDS configs whenever hash is present, which might cause problems.

Hypothetical situation is when instead of ports we'll decide to use sectionNames and if sectionName will contain - in the name

Needs information:

  • Kubernetes / DNS RFC which dictates port names - add link in this issue
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it kind/bug A bug labels Dec 2, 2024
@bartsmykla bartsmykla changed the title Replace - with _ before hash in MeshService name Replace - with _ before hash in identifiers in xDS config Dec 2, 2024
@bartsmykla bartsmykla added triage/needs-information Reviewed and some extra information was asked to the reporter and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Dec 2, 2024
@bartsmykla bartsmykla mentioned this issue Dec 2, 2024
Open
@johncowen johncowen mentioned this issue Dec 2, 2024
Merged
@lukidzi
Copy link
Contributor

lukidzi commented Dec 9, 2024

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#serviceport-v1-core
The name of this port within the service. This must be a DNS_LABEL. All ports within a ServiceSpec must have unique names. When considering the endpoints for a Service, this must match the 'name' field in the EndpointPort. Optional if only one ServicePort is defined on this service.

rfc1035/rfc1123 label (DNS_LABEL): An alphanumeric (a-z, and 0-9) string, with a maximum length of 63 characters, with the '-' character allowed anywhere except the first or last character, suitable for use as a hostname or segment in a domain name.

https://github.com/kubernetes/design-proposals-archive/blob/main/architecture/identifiers.md

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/needs-information Reviewed and some extra information was asked to the reporter labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartsmykla @lukidzi