diff --git a/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java b/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java index 4a75e0d8f6a3..a2ef7ff252ab 100644 --- a/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java +++ b/assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java @@ -1370,7 +1370,7 @@ public String buildMainPanelContext(VelocityPortlet portlet, Context context, Ru return template; - } // buildNormalContext + } // buildMainPanelContext /** * local function for getting assignment object diff --git a/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm b/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm index a94b93735bbb..c17aca06b965 100644 --- a/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm +++ b/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm @@ -352,6 +352,7 @@ tool-id="sakai.assignment" entity-id="$assignment.Id" evaluated-item-id="$submission.Id" + evaluated-item-owner-id="$submitterId" #if($!rbcs-state-details && "$!rbcs-state-details" != "") state-details='$rbcs-state-details' diff --git a/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission_withgrader.vm b/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission_withgrader.vm index dc65174d158b..cfe5dbbf4bd3 100644 --- a/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission_withgrader.vm +++ b/assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission_withgrader.vm @@ -1,4 +1,4 @@ - + #set( $H = '-' ) #javascript("/library/js/lang-datepicker/lang-datepicker.js") diff --git a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java index f5debc7f5a8e..cc88966fb905 100644 --- a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java +++ b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java @@ -321,52 +321,52 @@ public boolean isVisible() { gradeScore.add(new Label("outOf").setVisible(false)); - final WebMarkupContainer sakaiRubricPreview = new WebMarkupContainer("sakai-rubric-student-button"); - sakaiRubricPreview.add(AttributeModifier.append("display", "icon")); - sakaiRubricPreview.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_GRADEBOOKNG)); - sakaiRubricPreview.add(AttributeModifier.append("evaluated-item-id", assignment.getId() + "." + studentUuid)); - sakaiRubricPreview.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); + final WebMarkupContainer sakaiRubricButton = new WebMarkupContainer("sakai-rubric-student-button"); + sakaiRubricButton.add(AttributeModifier.append("display", "icon")); + sakaiRubricButton.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_GRADEBOOKNG)); + sakaiRubricButton.add(AttributeModifier.append("evaluated-item-id", assignment.getId() + "." + studentUuid)); + sakaiRubricButton.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); - addInstructorAttributeOrHide(sakaiRubricPreview, assignment.getId(), studentUuid, showingStudentView); + addInstructorAttributeOrHide(sakaiRubricButton, assignment.getId(), studentUuid, showingStudentView); if (assignment.getId() != null) { - sakaiRubricPreview.add(AttributeModifier.append("entity-id", assignment.getId())); + sakaiRubricButton.add(AttributeModifier.append("entity-id", assignment.getId())); } - gradeScore.add(sakaiRubricPreview); + gradeScore.add(sakaiRubricButton); } else { gradeScore.add( new Label("grade", FormatHelper.convertEmptyGradeToDash(FormatHelper.formatGradeForDisplay(rawGrade)))); gradeScore.add(new Label("outOf", new StringResourceModel("label.studentsummary.outof", null, assignment.getPoints()))); - final WebMarkupContainer sakaiRubricPreview = new WebMarkupContainer("sakai-rubric-student-button"); - sakaiRubricPreview.add(AttributeModifier.append("display", "icon")); - sakaiRubricPreview.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); + final WebMarkupContainer sakaiRubricButton = new WebMarkupContainer("sakai-rubric-student-button"); + sakaiRubricButton.add(AttributeModifier.append("display", "icon")); + sakaiRubricButton.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); - addInstructorAttributeOrHide(sakaiRubricPreview, assignment.getId(), studentUuid, showingStudentView); + addInstructorAttributeOrHide(sakaiRubricButton, assignment.getId(), studentUuid, showingStudentView); if (assignment.isExternallyMaintained()) { - sakaiRubricPreview.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_ASSIGNMENT)); + sakaiRubricButton.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_ASSIGNMENT)); String[] bits = assignment.getExternalId().split("/"); if (bits != null && bits.length >= 1) { String assignmentId = bits[bits.length-1]; String submissionId = rubricsService.getRubricEvaluationObjectId(assignmentId, studentUuid, RubricsConstants.RBCS_TOOL_ASSIGNMENT); - sakaiRubricPreview.add(AttributeModifier.append("entity-id", assignmentId)); - sakaiRubricPreview.add(AttributeModifier.append("evaluated-item-id", submissionId)); + sakaiRubricButton.add(AttributeModifier.append("entity-id", assignmentId)); + sakaiRubricButton.add(AttributeModifier.append("evaluated-item-id", submissionId)); } else { log.warn(assignment.getExternalId() + " is not a valid assignment reference"); } } else { - sakaiRubricPreview.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_GRADEBOOKNG)); - sakaiRubricPreview.add(AttributeModifier.append("evaluated-item-id", assignment.getId() + "." + studentUuid)); + sakaiRubricButton.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_GRADEBOOKNG)); + sakaiRubricButton.add(AttributeModifier.append("evaluated-item-id", assignment.getId() + "." + studentUuid)); if (assignment.getId() != null) { - sakaiRubricPreview.add(AttributeModifier.append("entity-id", assignment.getId())); + sakaiRubricButton.add(AttributeModifier.append("entity-id", assignment.getId())); } } - gradeScore.add(sakaiRubricPreview); + gradeScore.add(sakaiRubricButton); } if (gradeInfo != null && gradeInfo.isDroppedFromCategoryScore()) { gradeScore.add(AttributeModifier.append("class", "gb-summary-grade-score-dropped")); @@ -391,15 +391,15 @@ public boolean isVisible() { }); } - private void addInstructorAttributeOrHide(WebMarkupContainer sakaiRubricPreviewButton, Long assignmentId, String studentId, boolean showingStudentView) { + private void addInstructorAttributeOrHide(WebMarkupContainer sakaiRubricButton, Long assignmentId, String studentId, boolean showingStudentView) { if (!showingStudentView && (GradeSummaryTablePanel.this.getUserRole() == GbRole.INSTRUCTOR || GradeSummaryTablePanel.this.getUserRole() == GbRole.TA)) { - sakaiRubricPreviewButton.add(AttributeModifier.append("instructor", true)); + sakaiRubricButton.add(AttributeModifier.append("instructor", true)); } else { GradeDefinition gradeDefinition = businessService.getGradeForStudentForItem(studentId, assignmentId); if (gradeDefinition.getGrade() == null) { - sakaiRubricPreviewButton.setVisible(false); + sakaiRubricButton.setVisible(false); } } } diff --git a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java index 1ec24618e4c2..7ab693761aa6 100644 --- a/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java +++ b/gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java @@ -74,7 +74,8 @@ public void onInitialize() { sakaiRubricGrading.add(AttributeModifier.append("tool-id", RubricsConstants.RBCS_TOOL_GRADEBOOKNG)); sakaiRubricGrading.add(AttributeModifier.append("entity-id", assignmentId)); sakaiRubricGrading.add(AttributeModifier.append("evaluated-item-id", assignmentId + "." + studentUuid)); - sakaiRubricGrading.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); + sakaiRubricGrading.add(AttributeModifier.append("evaluated-item-owner-id", studentUuid)); + sakaiRubricGrading.add(AttributeModifier.append("token", rubricsService.generateJsonWebToken(RubricsConstants.RBCS_TOOL_GRADEBOOKNG))); form.add(sakaiRubricGrading); final GbAjaxButton submit = new GbAjaxButton("submit") { diff --git a/msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java b/msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java index bd6047bccbfa..ceb2782d8f80 100644 --- a/msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java +++ b/msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java @@ -6535,7 +6535,7 @@ public String generatePermissionScript(){ PermissionLevel contributorLevel = permissionLevelManager.getDefaultContributorPermissionLevel(); StringBuilder sBuffer = new StringBuilder(); - sBuffer.append("