act_police: remove unnecessary null pointer check

It already has a NULL pointer check of rtab in qdisc_put_rtab(). Remove the check outside of qdisc_put_rtab(). Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
kyagi · Dec 19, 2013 · 3b69a4c · 3b69a4c
1 parent d2adcaa
commit 3b69a4c
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
@@ -261,10 +261,8 @@ static int tcf_act_police_locate(struct net *net, struct nlattr *nla,
 failure_unlock:
 	spin_unlock_bh(&police->tcf_lock);
 failure:
-	if (P_tab)
-		qdisc_put_rtab(P_tab);
-	if (R_tab)
-		qdisc_put_rtab(R_tab);
+	qdisc_put_rtab(P_tab);
+	qdisc_put_rtab(R_tab);
 	if (ret == ACT_P_CREATED)
 		kfree(police);
 	return err;