Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable injection to top frames only #6

Open
yehudasabag opened this issue Jan 23, 2017 · 1 comment
Open

Enable injection to top frames only #6

yehudasabag opened this issue Jan 23, 2017 · 1 comment

Comments

@yehudasabag
Copy link

I really need the option to inject my scripts to only top frames and not all the iframes in the page.
I created this issue and will create a pull request for adding this kind of support.
What I had in mind is a global option (some kind of checkbox) for 'inject only to top frames' which will be off be default.
@kylepaulsen WDYT? Is it OK with you?
Thanks

@kylepaulsen
Copy link
Owner

This seems reasonable. I'll add it to my list of todo's. Feel free to submit a PR and I'll give it a look. Otherwise I'll get around to it eventually.

For the time being, you can do a quick fix yourself with a check in your inject rule to see if you are in a frame before executing what you want: http://stackoverflow.com/questions/326069/how-to-identify-if-a-webpage-is-being-loaded-inside-an-iframe-or-directly-into-t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants