Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting Params is too difficult #2254

Open
Zethson opened this issue Dec 4, 2024 · 1 comment
Open

Deleting Params is too difficult #2254

Zethson opened this issue Dec 4, 2024 · 1 comment
Assignees
@falexwolf

Comments

@Zethson
Copy link
Member

Zethson commented Dec 4, 2024 •
edited
Loading

Add a description

I needed to delete some Transform that had Params (Run) and therefore also needed to delete the ParamValues. It was not obvious to me that they are in lamindb.core. Moreover, it was even less obvious that I need to delete RunParamValue which I can only access if I directly access lnschema_core. No user will ever get that.

I was still annoyed that #1547 is not yet implemented. Maybe I'll do it at some point.
@Zethson Zethson changed the title ParamValue is in core which is not obvious and makes it annoying to delete Deleting Params is too difficult Dec 4, 2024
@falexwolf
Copy link
Member

Yes, so my plan was adding run.params.remove_values() in analogy to what I did for features a week ago:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falexwolf falexwolf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@falexwolf @Zethson