Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 ln.track should prompt to enter any key instead of y or n with an error #2265

Open
Koncopd opened this issue Dec 6, 2024 · 3 comments
Assignees
Labels

Comments

@Koncopd
Copy link
Member

Koncopd commented Dec 6, 2024

Add a description

subj

@Koncopd Koncopd changed the title ln.track should prompt to enter any key instaed of y or n with an error ln.track should prompt to enter any key instead of y or n with an error Dec 6, 2024
@falexwolf
Copy link
Member

Can then also make this message analogous so that it no longer raises an error but the same analogous dialogue in a notebook.

image

@falexwolf falexwolf self-assigned this Dec 16, 2024
@falexwolf falexwolf changed the title ln.track should prompt to enter any key instead of y or n with an error 🚸 ln.track should prompt to enter any key instead of y or n with an error Dec 16, 2024
@ap--
Copy link
Contributor

ap-- commented Dec 16, 2024

Just fyi, because a user ran into this:

There can be a deadlock in older jupyterlab versions where when the input is displayed and a user manually reruns the cell, the kernel deadlocks. Might be worth not showing the input when running in older jupyter lab versions

jupyterlab/jupyterlab#8713
jupyterlab/jupyterlab#16032

Seems to be fixed in:

  • 3.x branch: 3.1.0+
  • 4.x branch: 4.2.0+

@falexwolf
Copy link
Member

Thanks for sharing! We'll account for this in one way or the other. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants