Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Pagination Type #36

Closed
edcs opened this issue Aug 26, 2016 · 1 comment
Closed

Result Pagination Type #36

edcs opened this issue Aug 26, 2016 · 1 comment

Comments

@edcs
Copy link

edcs commented Aug 26, 2016

I've just implemented Scout on an API I've been building. I'm using Fractal by the PHP League which has baked in support for Laravel pagination using \Illuminate\Pagination\LengthAwarePaginator.

The documentation for Scout states the following (https://laravel.com/docs/5.3/scout#pagination):

In addition to retrieving a collection of models, you may paginate your search results using the paginate method. This method will return a Paginator instance just as if you had paginated a traditional Eloquent query.

However, Scout returns an instance of Illuminate\Pagination\Paginator where as Eloquent returns an instance of \Illuminate\Pagination\LengthAwarePaginator. Before I spend too much effort on this, is there any reason why Scout returns a different type of paginator to Eloquent? This seems a bit like an issue since the documentation suggests that it's pagination should be the same as Eloquent's.

@EdwardNelson
Copy link

Fixed with #62 it just needs to be tagged

@themsaid themsaid closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants