Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to shape Waffles as a rectangle, not only as a square or dot #507

Open
Blindstars opened this issue May 28, 2024 · 0 comments

Comments

@Blindstars
Copy link

Is your feature request related to a problem? Please describe.
The Waffle widget only has a dim parameter which forces dotty or square WafflePixels.

Describe the solution you'd like
Have to ability to size a Waffle as a rectangle in both X and Y dimensions. I have done something similar in one of my own projects:

image

Describe alternatives you've considered
I have done this in one of my own projects by overriding a couple methods from Waffle and WafflePixel. We could instead add a parameter to the Waffle for the other dimension and refactor WafflePixel to handle both dimensions parameters. dotty would be unaffected by this since it would only use the existing dim parameter.

Additional context
I can propose a PR implementing this feature if this is of interest for the team. Still need to figure out proper parameters implementation for dim_x and dim_y without breaking backwards compatibility. I am guessing we should conserve dim and only add dim_y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant