Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach Quiz Side Panels need refactoring #12840

Open
3 tasks
nucleogenesis opened this issue Nov 13, 2024 · 0 comments
Open
3 tasks

Coach Quiz Side Panels need refactoring #12840

nucleogenesis opened this issue Nov 13, 2024 · 0 comments
Assignees

Comments

@nucleogenesis
Copy link
Member

Overview

In Quiz Creation there is a SectionSidePanel component which wraps a SidePanelModal around the <router-view /> into which the "side panel components" render. This results in clobbering our ability to handle each route individually and complicates routing by putting the onus for some routing decisions on that SectionSidePanel component.

Description and outcomes

We should instead simply leverage VueRouter and it's guards and keep the logic of "where do I go and why" up to the individual "side panel components" (ie, ResourceSelection, ReplaceQuestions, SectionEditor, etc).

By removing SectionSidePanel each of those components then can render as a SidePanelModal themselves. Then, the <router-view /> where those components render can live in the CreateExamPage/index component.

Then these components can be shown/hidden depending on whether or not the user is on a "side panel" route or not -- in this case, the only non-side-panel route is the EXAM_CREATION_ROOT page component. If we opted to have others, then this display logic can be updated more easily than it is currently.

Acceptance criteria

  • Remove SectionSidePanel component
  • Handle side panel exiting and/or going back for each page within their relevant component
  • No regressions in quiz creation when navigating side panels
@nucleogenesis nucleogenesis self-assigned this Nov 13, 2024
@nucleogenesis nucleogenesis linked a pull request Nov 13, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant