Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes - Import from other channels - The 'Show more' button is not centered #4838

Open
pcenov opened this issue Nov 22, 2024 · 21 comments
Open
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: ux update

Comments

@pcenov
Copy link
Member

pcenov commented Nov 22, 2024

Observed behavior

The 'Show more' button is not centered at the 'Import from other channels' modal.

Image

Expected behavior

The button should be centered for constancy as it's centered everywhere else.

Steps to reproduce the issue

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel and click Add > Import from channels > African Storybook Library (multiple languages) > Afrikaans > Level 2

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Nov 22, 2024

@radinamatic

@rishisulakhe
Copy link

Hi @pcenov
I can solve this, pls assign it to me!!

@bjester
Copy link
Member

bjester commented Nov 22, 2024

Hi @rishisulakhe,

Thank you for your interest. I've assigned you this issue. Please follow these guidelines to get started, if you haven't already https://github.com/learningequality/studio?tab=readme-ov-file#how-can-i-contribute

Let us know if you run into issues

@MisRob MisRob added good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome labels Dec 2, 2024
@hsd2514
Copy link

hsd2514 commented Dec 2, 2024

is this issue still open

@MisRob
Copy link
Member

MisRob commented Dec 2, 2024

Hi @hsd2514, it's already assigned. You're welcome to find another 'help wanted' with no assignee.

@jayesh9747
Copy link

@MisRob @pcenov, I don’t think this issue should take three weeks to fix. Can I start working on it now? I can complete it within a day.

@MisRob
Copy link
Member

MisRob commented Dec 11, 2024

Hi @jayesh9747, thanks for volunteering. Many contributors are students or have other responsibilities, and we really don't expect to receive solution within days to not make contributing experience into pressure. Let's wait a couple of days to hear from @rishisulakhe whether this is in progress or no. If we don't hear back, I'm happy to reassign.

@jayesh9747
Copy link

@MisRob , okay sure. i give my quick introduction.I am Jayesh Savaliya, a third-year B.Tech student in Computer Science and Engineering at IIIT Pune, graduating in 2026. I have a strong interest in full-stack development, particularly in the MERN stack and Django backend framework, and have hands-on experience in Python for machine learning projects. My open-source contributions include Dalgo-admin and the OpenKruise-dashboard, and I have also interned under the C4GT mentorship program with ShikshaLokam.I am very keen to contribute.

@MisRob
Copy link
Member

MisRob commented Dec 11, 2024

Welcome @jayesh9747!

@Md-Murthaza
Copy link

Hello @MisRob Is the issue fixed .I love to do this as my first issue.

@jayesh9747
Copy link

@rishisulakhe , are you still working ? otherwise i would to contribute this issue.

@Md-Murthaza
Copy link

@jayesh9747 , This issue can be fixed within a day .Isn't it ?

@MisRob
Copy link
Member

MisRob commented Dec 12, 2024

Friends, as mentioned above, let's give some time to @rishisulakhe ;) I recommend to read existing issue comments before posting - you can see we decided to wait. We typically unassign after a month of inactivity. You're welcome to post an assignment request on free 'help wanted' issues and enjoy contributing in whatever pace works for you.

@Md-Murthaza
Copy link

@MisRob Thanks, for clarifying it . we will wait and focus on some other issues.

@MisRob
Copy link
Member

MisRob commented Dec 12, 2024

Thanks @Md-Murthaza. There will be more new contributing opportunities by the end of January or so, and we regularly cleanup stale assignments and label new issues, so it's best to keep an eye on it regularly.

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Hi @jayesh9747, I will now re-assign to you because @rishisulakhe didn't respond and it's been a month since the assignment. Feel free to take work on this if you're still interested, thanks! Also I wanted to mention that Learning Equality will be closed from December 23 to January 5.

@MisRob MisRob assigned jayesh9747 and unassigned rishisulakhe Dec 17, 2024
@jayesh9747
Copy link

@MisRob , i will complete very soon.

@jayesh9747
Copy link

@pcenov @MisRob , I believe the actual issue is that the 'Show More' button is not centered. Additionally, if I revisit the same page, the 'Show More' button does not appear.

First-Time Visit:
Image

Second time visiting :
Image

Moreover, in Level 2, there are 35 resources, but when revisiting the page, the 'Show More' button does not appear. I suspect this happens because the content is preloaded, resulting in only 25 documents being loaded, as shown in the first visit. This is also evident in the screenshot below:
Image

Finally, I’d like to ask: should I fix this issue within this thread, or should I create a new issue for it?

@jayesh9747
Copy link

@MisRob can you clarify this issue ? should I process or not ?

@AlexVelezLl
Copy link
Member

AlexVelezLl commented Dec 18, 2024

Hey @jayesh9747! Thanks! It seems that you spotted an issue in our pagination process :). I dont see an open issue reporting this. So please feel free to open a new issue reporting this.

@jayesh9747
Copy link

@AlexVelezLl @MisRob please check Review PR#4864.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have TAG: ux update
Projects
None yet
Development

No branches or pull requests

8 participants