From 8aa3556929195c26fd40f7b57a66928e482c0622 Mon Sep 17 00:00:00 2001 From: Zekun Li Date: Thu, 24 Mar 2022 23:32:33 -0700 Subject: [PATCH] [AptosFramework] add TODO and link issues for ignored tests Closes: #314 --- api/Cargo.toml | 14 +++++++------- testsuite/smoke-test/src/consensus.rs | 1 + testsuite/smoke-test/src/operational_tooling.rs | 15 +++++++++++++++ testsuite/testcases/src/reconfiguration_test.rs | 1 + 4 files changed, 24 insertions(+), 7 deletions(-) diff --git a/api/Cargo.toml b/api/Cargo.toml index 5b8f28b64564e..e0be9ead994df 100644 --- a/api/Cargo.toml +++ b/api/Cargo.toml @@ -37,24 +37,24 @@ move-core-types = { git = "https://github.com/diem/move", rev = "8a260b82dda8175 move-resource-viewer = { git = "https://github.com/diem/move", rev = "8a260b82dda8175a98ea848fab5adcce467585b3" } [dev-dependencies] +goldenfile = "1.1.0" rand = "0.8.3" reqwest = { version = "0.11.2", features = ["blocking", "json"], default_features = false } -goldenfile = "1.1.0" -mempool-notifications = { path = "../state-sync/inter-component/mempool-notifications" } -aptosdb = { path = "../storage/aptosdb", features = ["fuzzing"] } aptos-crypto = { path = "../crates/aptos-crypto" } +aptos-framework-releases = { path = "../aptos-move/framework/aptos-framework/releases" } +aptos-genesis-tool = {path = "../config/management/genesis", features = ["testing"] } aptos-global-constants = { path = "../config/global-constants" } aptos-mempool = { path = "../mempool", features = ["fuzzing"] } +aptos-sdk = { path = "../sdk" } aptos-secure-storage = { path = "../secure/storage" } aptos-temppath = { path = "../crates/aptos-temppath" } -aptos-genesis-tool = {path = "../config/management/genesis", features = ["testing"] } -aptos-framework-releases = { path = "../aptos-move/framework/aptos-framework/releases" } -aptos-sdk = { path = "../sdk" } -vm-validator = { path = "../vm-validator" } aptos-vm = { path = "../aptos-move/aptos-vm" } +aptosdb = { path = "../storage/aptosdb", features = ["fuzzing"] } executor = { path = "../execution/executor" } executor-types = { path = "../execution/executor-types" } +mempool-notifications = { path = "../state-sync/inter-component/mempool-notifications" } +vm-validator = { path = "../vm-validator" } [features] failpoints = ["fail/failpoints"] diff --git a/testsuite/smoke-test/src/consensus.rs b/testsuite/smoke-test/src/consensus.rs index b766d2aaa644e..bb6609c67f98d 100644 --- a/testsuite/smoke-test/src/consensus.rs +++ b/testsuite/smoke-test/src/consensus.rs @@ -60,6 +60,7 @@ async fn test_consensus_observer_mode_storage_error() { assert_eq!(sequence_number_0, sequence_number_1); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317): add back after support update consensus config in aptos-framework // #[allow(dead_code)] // async fn test_onchain_upgrade(new_onfig: OnChainConsensusConfig) { // let num_nodes = 4; diff --git a/testsuite/smoke-test/src/operational_tooling.rs b/testsuite/smoke-test/src/operational_tooling.rs index f662403295675..555e7627b4eb1 100644 --- a/testsuite/smoke-test/src/operational_tooling.rs +++ b/testsuite/smoke-test/src/operational_tooling.rs @@ -84,6 +84,7 @@ async fn test_account_resource( ); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_auto_validate_options() { @@ -117,6 +118,7 @@ async fn test_auto_validate_options() { assert!(txn_ctx.execution_result.unwrap().success); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_consensus_key_rotation() { @@ -217,6 +219,7 @@ async fn test_create_validator_bcs_file( .await; } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_disable_address_validation() { @@ -268,6 +271,7 @@ async fn test_disable_address_validation() { .unwrap(); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_set_operator_and_add_new_validator() { @@ -446,6 +450,7 @@ async fn test_set_operator_and_add_new_validator() { assert!(!txn_ctx.execution_result.unwrap().success); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] // Because each test takes non-neglible time to start, streamlining them into a single test @@ -557,6 +562,7 @@ async fn test_extract_peer_from_storage( assert_eq!(expected_peer_id, *peer_id); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_extract_peer_from_file() { @@ -576,6 +582,7 @@ async fn test_extract_peer_from_file() { assert_eq!(from_identity_public_key(public_key), *peer_id); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_extract_peers_from_keys() { @@ -607,6 +614,7 @@ async fn test_extract_peers_from_keys() { } } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_generate_key() { @@ -708,6 +716,7 @@ async fn test_insert_waypoint( ); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_fullnode_network_key_rotation() { @@ -748,6 +757,7 @@ async fn test_fullnode_network_key_rotation() { assert_eq!(new_network_key, info_network_key); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_network_key_rotation() { @@ -797,6 +807,7 @@ async fn test_network_key_rotation() { .unwrap(); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_network_key_rotation_recovery() { @@ -850,6 +861,7 @@ async fn test_network_key_rotation_recovery() { .unwrap(); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_operator_key_rotation() { @@ -885,6 +897,7 @@ async fn test_operator_key_rotation() { assert_eq!(new_consensus_key, config_consensus_key); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_operator_key_rotation_recovery() { @@ -1009,6 +1022,7 @@ async fn test_print_waypoints( assert_eq!(inserted_waypoint, genesis_waypoint); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_validator_config() { @@ -1058,6 +1072,7 @@ async fn test_validator_config() { ); } +// TODO(https://github.com/aptos-labs/aptos-core/issues/317) #[ignore] #[tokio::test] async fn test_validator_set() { diff --git a/testsuite/testcases/src/reconfiguration_test.rs b/testsuite/testcases/src/reconfiguration_test.rs index 8d6693a98704e..6385426450d21 100644 --- a/testsuite/testcases/src/reconfiguration_test.rs +++ b/testsuite/testcases/src/reconfiguration_test.rs @@ -16,6 +16,7 @@ impl NetworkTest for ReconfigurationTest { fn run<'t>(&self, _ctx: &mut NetworkContext<'t>) -> Result<()> { Err(anyhow!("Not supported in aptos-framework yet")) } + // TODO(https://github.com/aptos-labs/aptos-core/issues/317): add back after support those transactions in aptos-framework // let rt = Runtime::new()?; // // let mut rng = StdRng::from_seed(OsRng.gen());