Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node migration option to provide own seed #6

Open
tmchow opened this issue Oct 15, 2018 · 3 comments
Open

Node migration option to provide own seed #6

tmchow opened this issue Oct 15, 2018 · 3 comments
Assignees
Labels
enhancement New core feature or request

Comments

@tmchow
Copy link

tmchow commented Oct 15, 2018

Feature request:

Param to take in an existing seed for those people that are setting up new node and need to use an existing seed. I've setup my node like a dozen times in the last 6 months for a variety of reasons, so this would save me some time. I'm sure others have this need as well.

@lephleg
Copy link
Owner

lephleg commented Oct 17, 2018

@tmchow thanks for the suggestion. I've also thought of it a while ago. It's definitely something I'd use a lot too.

However, the reason I didn't include it as part of the installer was the security concerns it may raise to some people. Asking for a wallet seed as part of an automated sudo script may ring some bells (it would to me). Especially user with no clear overview of how the whole stack operates could criticize it and not spare a minute to check the actual code.

On the other hand, I may implement it and mark it with a bold note for those that may want to use it after they've dig in more. Haven't decide yet.

@lephleg lephleg added the enhancement New core feature or request label Oct 17, 2018
@tmchow
Copy link
Author

tmchow commented Oct 17, 2018

@lephleg Good point. Perhaps a good middle ground is:

  1. add flag for migration but don't take seed as a param
  2. instead just output a message at the every end on what syntax the user should do to change the seed

@lephleg
Copy link
Owner

lephleg commented Feb 23, 2019

Nano node v.18 brings a new option on the --wallet_create CLI command which allows a new wallet to be imported using a provided seed:

$ docker exec -it nano-node --wallet_create --key=<seed>

This could make things way easier for the installer too. I'll give it a go on first chance.

@lephleg lephleg self-assigned this Feb 23, 2019
Repository owner deleted a comment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New core feature or request
Projects
None yet
Development

No branches or pull requests

2 participants