Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration reply should include same Link headers as new registration #508

Closed
r0ro opened this issue Jul 22, 2015 · 2 comments · Fixed by #509
Closed

Registration reply should include same Link headers as new registration #508

r0ro opened this issue Jul 22, 2015 · 2 comments · Fixed by #509

Comments

@r0ro
Copy link
Contributor

r0ro commented Jul 22, 2015

If we want to retrieve Registration info from the client key pair, we can send a new-reg request.
We then get a 409 error with 'Location' header set to the Registration resource url.
We then use an empty POST update request to this url.
In the reply we don't have the "next" nor "terms-of-service" Link headers

@jsha
Copy link
Contributor

jsha commented Jul 22, 2015

Currently the spec (https://github.com/letsencrypt/acme-spec/blob/master/draft-barnes-acme.md) only specifies those Link headers for new-registration responses, not for existing registrations. That seems like a bug in the spec: Can you send a pull request against the spec indicating that existing registrations should provide those link headers also? We need to merge the spec fix before we can merge the Boulder fix. Thanks for spotting this!

@r0ro
Copy link
Contributor Author

r0ro commented Jul 23, 2015

done: letsencrypt/acme-spec#198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants