Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming files, classes and functions #120

Open
rianrietveld opened this issue Jun 26, 2018 · 0 comments
Open

Naming files, classes and functions #120

rianrietveld opened this issue Jun 26, 2018 · 0 comments
Milestone
0.4.0 - breaking

Comments

@rianrietveld
Copy link

The following names cause errors with phpcs

File naming

  • Class file names should be based on the class name with "class-" prepended.
  • Filenames should be all lowercase with hyphens as word separators. This is the case for the files in the wordpress-objects dir.
  • Method name "_refresh_data" should not be prefixed with an underscore to indicate visibility

I propose to rename those files/methods.

This also means the we need to move the class Clarkson_Coreoutside the main clarkson-core.php file.
@jmslbam jmslbam added this to the 0.4.0 milestone Jun 27, 2018
@jmslbam jmslbam modified the milestones: 0.3.2, 0.4.0 - breaking Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
0.4.0 - breaking
Development

No branches or pull requests
2 participants
@jmslbam @rianrietveld