Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for a plugin #81

Open
darosior opened this issue Jan 11, 2020 · 8 comments
Open

Ideas for a plugin #81

darosior opened this issue Jan 11, 2020 · 8 comments
Labels

Comments

@darosior
Copy link
Member

darosior commented Jan 11, 2020

  • A plugin that generates a QR code out of a newaddr to fund lightningd's wallet from a mobile wallet

  • A Bitcoin backend plugin for your favourite data source, you can checkout Sauron as an example.

@m-schmoock
Copy link
Member

Yeah like the python qr generator that uses ASCII output that actually works great :D

@cdecker
Copy link
Contributor

cdecker commented Jan 13, 2020

  • A plugin that generates a QR code out of a newaddr to fund lightningd's wallet from a mobile wallet

You mean an ASCII QR code that prints to stdout, or a web-server that displays the QR code as an image?

@darosior
Copy link
Member Author

I meant just ASCII, like spark-wallet does for onion pairing

@m-schmoock
Copy link
Member

▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░▉▉▉▉▉▉▉▉▉▉░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░░░░░░░
▉░░░░░░░░▉▉░░░░░░░░░░▉▉░░▉▉░░▉▉░░▉▉░░▉▉░░░░░░░░░░▉▉░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░▉▉░░░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░▉▉▉▉▉▉▉▉░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░░░░░░░▉▉░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░░░░░
▉░░░░░░░░▉▉░░░░░░░░░░▉▉░░▉▉▉▉░░▉▉░░░░▉▉░░░░░░░░░░▉▉░░░░░░░░
▉░░░░░░░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░▉▉░░▉▉░░▉▉░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░▉▉▉▉▉▉▉▉░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░▉▉▉▉░░░░▉▉▉▉▉▉░░░░▉▉░░▉▉░░░░░░▉▉░░▉▉▉▉▉▉▉▉░░░░░░░░
▉░░░░░░░░░░░░▉▉░░▉▉▉▉░░▉▉▉▉▉▉▉▉▉▉▉▉░░▉▉░░▉▉▉▉░░▉▉░░░░░░░░░░
▉░░░░░░░░░░░░▉▉░░▉▉▉▉▉▉▉▉░░░░░░▉▉░░▉▉░░░░▉▉░░▉▉▉▉░░░░░░░░░░
▉░░░░░░░░▉▉▉▉░░░░▉▉▉▉░░▉▉░░░░▉▉░░░░▉▉░░▉▉▉▉░░░░▉▉▉▉░░░░░░░░
▉░░░░░░░░▉▉░░░░▉▉░░░░▉▉▉▉▉▉▉▉░░░░▉▉▉▉░░▉▉░░░░░░░░▉▉░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░▉▉░░░░░░▉▉▉▉▉▉░░▉▉▉▉░░▉▉░░░░░░░░░░
▉░░░░░░░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░░░░░▉▉░░▉▉▉▉░░░░▉▉░░▉▉▉▉░░░░░░░░░░
▉░░░░░░░░▉▉░░░░░░░░░░▉▉░░▉▉░░░░▉▉▉▉░░░░░░▉▉░░░░▉▉░░░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░▉▉░░▉▉▉▉░░▉▉▉▉░░▉▉░░░░▉▉░░░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░▉▉░░▉▉▉▉░░░░░░▉▉▉▉▉▉▉▉▉▉░░░░░░░░
▉░░░░░░░░▉▉░░▉▉▉▉▉▉░░▉▉░░░░▉▉░░▉▉░░░░▉▉░░▉▉▉▉░░░░░░░░░░░░░░
▉░░░░░░░░▉▉░░░░░░░░░░▉▉░░▉▉░░░░░░░░▉▉▉▉▉▉▉▉▉▉░░░░░░░░░░░░░░
▉░░░░░░░░▉▉▉▉▉▉▉▉▉▉▉▉▉▉░░▉▉▉▉▉▉░░▉▉▉▉▉▉░░░░░░░░░░▉▉░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
▉░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░

@renepickhardt
Copy link
Contributor

https://superuser.com/questions/1420001/is-it-possible-to-create-a-qr-code-using-text

actually I think UTF-8 or ANSI would be nicer and probably work better. I guess we should not use that tool otherwise I would quickly create a wrapper for a plugin. on the other hand why not using a third party lib in a plugin

@GlenCooper
Copy link

Screenshot from 2020-02-19 05-53-39
that QR was generated by going in any browser to: https://qrenco.de/https://github.com/lightningd/plugins/issues/81
code behind qrenco.de is open source = https://github.com/fukuchi/libqrencode

@citrusferox
Copy link

lightning-cli newaddr | jq -r '.bech32' | qrencode -t UTF8

newaddr

lightning-cli invoice 123456 qrtest qrtest | jq -r '.bolt11' | qrencode -t UTF8

invoice_qr

too linux-way though, if you ask me...

Is it possible to pass an additional flag to existing cli command and catch it with a plugin?
Then introducing --qrencode flag would help UX

@darosior
Copy link
Member Author

darosior commented Apr 5, 2020

Is it possible to pass an additional flag to existing cli command and catch it with a plugin?

Nop, but you can introduce a new command qr-newaddr which returns the QR-encoded output of newaddr command (same for bolt11).

You could also use the rpc_command hook to wrap newaddr and bolt11 with a new parameter, which, if set to true would make the output QR-encoded.
This has the benefit of neither having to use a different command nor disturbing other users of this command.

@cdecker cdecker added the ideas label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants