New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `Flags.serverGracefulShutdownTimeout()` in Armeria 2.0 #5732

Open

ikhoon opened this issue Jun 5, 2024 · 0 comments

Labels

breaking change

Milestone

Contributor

ikhoon commented Jun 5, 2024

#5718 (comment)

@minwoox wrote:
I think we can probably do it when we reach 2.0:

Move ServerBuilder.DEFAULT_GRACEFUL_SHUTDOWN_TIMEOUT to Flags
Increase ServerBuilder.DEFAULT_GRACEFUL_SHUTDOWN_TIMEOUT value from zero
Use the value for the client factory as well.

ikhoon added the breaking change label

ikhoon added this to the 2.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment