Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall view should have dynamic width for SVG DOM #97

Open
xxkennyxu opened this issue Oct 18, 2016 · 2 comments
Open

Waterfall view should have dynamic width for SVG DOM #97

xxkennyxu opened this issue Oct 18, 2016 · 2 comments

Comments

@xxkennyxu
Copy link

The DOM element for the Waterfall view is statically set to 1220px.

var WIDTH = 960, MARGIN = {
top : 40,
bottom : 10,
left : 10,
right : 250
}

var svg = root.append('svg')
.attr('width', WIDTH + MARGIN.left + MARGIN.right), vis = svg.append('g')
.attr('transform', 'translate(' + MARGIN.left + ',' + MARGIN.top + ')');

This causes a problem when tracing a very complicated call as it crops content once it exceeds the pre-set 1220px width.

It would be very helpful if this width was screen dependent and/or the overflow on the SVG would be handled by a scrollable container or some sort.

@jodzga
Copy link

jodzga commented Oct 18, 2016

Thanks for reporting this.
Could you give an example trace that displays incorrectly?
Also, we are accepting PRs ;-)

@xxkennyxu
Copy link
Author

Any API call that has nested downstream calls which results in a more complicated trace.

Another reason why the trace exceeds the width, is because if you don't give a descriptor for your ParSeq Task (during .map, .flatmap ...), it will default to the [package].[classname].[method]. Naming will help, but ultimately dealing with the overflow is the only viable solution.

Haha, good point! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants