Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make littleflash a submodule #1

Open
phatpaul opened this issue Mar 14, 2019 · 7 comments
Open

make littleflash a submodule #1

phatpaul opened this issue Mar 14, 2019 · 7 comments

Comments

@phatpaul
Copy link

Would you please split this up so I can include just the littleflash part in my ESP-IDF project as a git submodule?

I.e. just like you did with extflash.

I want to include it in my PR chmorgan/esphttpd-freertos#12 but the maintainer doesn't want any duplicated code, just submodules.

@lllucius
Copy link
Owner

Should be good now. Let me know if it doesn't work as you wanted.

@phatpaul
Copy link
Author

Thanks, but I think there some recursion hell going on.

In file included from C:/msys32/home/labview/esphttpd-freertos/main/user_main.c:76:0:
C:/msys32/home/labview/esphttpd-freertos/components/littleflash/components/littleflash/include/littleflash.h:24:22: fatal error: extflash.h: No such file or directory
compilation terminated.

that file is at
"C:\msys32\home\labview\esphttpd-freertos\components\littleflash\components\extflash\components\extflash\include\extflash.h"

Maybe is there not allowed to be multiple components with the same name? (there are 2 levels of extflash)

@lllucius
Copy link
Owner

Hmmm, I wonder why it failed there. I've attached a directory listing showing the tree I tested it in and it built fine. I suspect it's because I have an "extflash" in the httpd/components directory. I don't believe the littlefs/components/extflash fella is used when you're using this sort of hieirarchy.

tree.txt

@lllucius lllucius reopened this Mar 14, 2019
@lllucius
Copy link
Owner

lllucius commented Mar 14, 2019

Did you happen to do the "git submodule init/update" in the littleflash directory? I set up a clean tree and didn't do the "init/update" in the littleflash directory and littleflash/components/extflash was not pulled down, so it wouldn't pollute your tree with too much extra stuff.

@phatpaul
Copy link
Author

Oh, I did not add extflash to my first-level components directory (since I wasn't planning to use it).
I tried adding it to see if it compiles, but it gives new errors.
First one is below. Seems it is not expecting C++?

C:/msys32/home/labview/esphttpd-freertos/components/extflash/components/extflash/include/extflash.h:52:1: error: unknown type name 'class'
 class ExtFlash
 ^

@phatpaul
Copy link
Author

Sorry I didn't realize your port was in C++.
I guess there is not an easy way to use it from a C project? (without converting the project main.c to cpp)

@lllucius
Copy link
Owner

lllucius commented Mar 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants