fix WeakDictionary thread-safety

neuecc · neuecc · commit d277936ed633 · 2018-09-21T14:00:07.000+09:00
diff --git a/Assets/Plugins/UniRx/Scripts/Async/Internal/WeakDictionary.cs b/Assets/Plugins/UniRx/Scripts/Async/Internal/WeakDictionary.cs
@@ -46,6 +46,7 @@ public bool TryGetValue(TKey key, out TValue value)
             bool lockTaken = false;
             try
             {
+                gate.Enter(ref lockTaken);
                 if (TryGetEntry(key, out _, out var entry))
                 {
                     value = entry.Value;
@@ -66,6 +67,7 @@ public bool TryRemove(TKey key)
             bool lockTaken = false;
             try
             {
+                gate.Enter(ref lockTaken);
                 if (TryGetEntry(key, out var hashIndex, out var entry))
                 {
                     Remove(hashIndex, entry);

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ public bool TryGetValue(TKey key, out TValue value)`
`46`	`46`	`bool lockTaken = false;`
`47`	`47`	`try`
`48`	`48`	`{`
	`49`	`+ gate.Enter(ref lockTaken);`
`49`	`50`	`if (TryGetEntry(key, out _, out var entry))`
`50`	`51`	`{`
`51`	`52`	`value = entry.Value;`
`@@ -66,6 +67,7 @@ public bool TryRemove(TKey key)`
`66`	`67`	`bool lockTaken = false;`
`67`	`68`	`try`
`68`	`69`	`{`
	`70`	`+ gate.Enter(ref lockTaken);`
`69`	`71`	`if (TryGetEntry(key, out var hashIndex, out var entry))`
`70`	`72`	`{`
`71`	`73`	`Remove(hashIndex, entry);`