-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometime asyncBusboy never responding #56
Comments
Probably duplicate of #49 |
I don't think the issue is with async-busboy, but instead Koa. NodeJS http library is closing the request when I would expect it not to. The issue here is, I think, figuring out why http is issuing the close event, when we are in the depths of our application code 🤔 |
jeffrinmathewbenny
added a commit
to jeffrinmathewbenny/async-busboy
that referenced
this issue
May 22, 2024
jeffrinmathewbenny
added a commit
to jeffrinmathewbenny/async-busboy
that referenced
this issue
May 22, 2024
jeffrinmathewbenny
added a commit
to jeffrinmathewbenny/async-busboy
that referenced
this issue
May 22, 2024
async-busboy-freeze-fix: fix the async-busboy freeze issue mentioned m4nuC#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes I found that asyncBusboy not responding because promise never resolved or rejected.
I traced inside asyncBusBoy source code and I found that sometimes request's 'close' event handler called
before busboy's 'finish' handler ( before onEnd called).
I modified source code like "request.on('close', onEnd)" instead of "request.on('close', cleanup)" and it works perfectly.
I'm afraid I'm doing wrong and make some side effects. Replacing handler to onEnd instead of cleanup is safe?
The text was updated successfully, but these errors were encountered: