Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a npm package for this module? #10

Closed
aalexgabi opened this issue Jun 29, 2018 · 7 comments
Closed

Is there a npm package for this module? #10

aalexgabi opened this issue Jun 29, 2018 · 7 comments

Comments

@aalexgabi
Copy link

I can't seem to find one.

In case this is not published, what do you think about publishing it?

@madmurphy
Copy link
Owner

Hi Aalex!

I have no idea actually, I am just the guy who wrote the code.

It would be great to publish it though! Unfortunately I will have no time for some weeks. What would you think about publishing it yourself?

@kirly-af
Copy link
Contributor

kirly-af commented Jul 2, 2018

@madmurphy, @aalexgabi
There's already this module: https://www.npmjs.com/package/doc-cookies
I opened bibliolabs/docCookies#7 to upgrade to revision 3 and @evanmuller seems to be ok with that.

Maybe in the future one of these 2 repos should be deprecated?

@kirly-af
Copy link
Contributor

kirly-af commented Jul 2, 2018

See #11

@madmurphy
Copy link
Owner

@kirly-af

Many thanks!

Maybe in the future one of these 2 repos should be deprecated?

Well, I guess as the author I should not deprecate myself ;)

@evanmuller
Copy link

@madmurphy glad @kirly-af found the original author of this code. I updated the npm package to point to your repo. I can make you a collaborator and even take myself and bibliolabs off the package if you want to take over ownership. Do you have an npm username?

@madmurphy
Copy link
Owner

@evanmuller Thank you and sorry for the late answer! Unfortunately I do not have a npm username. But feel free to use your repo! P.S. I just realeased an update btw.

@markcellus
Copy link

So just to clarify, which repository have we settled on as the repo associated with the doc-cookies and cookies.js package? And which npm package is considered the one we should all use?

https://github.com/jasonkarns/doc-cookies seems outdated and doesn't have the typescript declaration file.

It's been a convention to have the repo name be the same as the npm package name. Let me know if I can help out at all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants