-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser support #70
Comments
Assuming its easy to maintain I'm 👍 |
Any preference for global variable name? Maybe |
I trust your judgement :) |
+1 I think it is not just speed. compared to other libraries (tv4, jsen), is-my-json-valid is good with complex validations. Ref: bugventure/jsen#38 This schema works as expected in is-my-json-valid. Browser support will be really helpful to get this to plain HTML applications also. |
If anyone wants to do a PR for this I'd merge it |
Is it a complicated task to make it available to the browser? just asking, I have no idea ;) Is it coming? |
@Basdub you can use in the browser today with browserify. like i mentioned above its pretty easy to do static builds. we just need someone to add a script to package.json that will do that for us so we don't have to do it manually every time we publish a new version |
Yep get that. You'll laugh but I'm not Node.js ready/setup yet. @chrahunt , could you provide your script to add to package.json? Thanks |
Or, @chrahunt, could I get your browserified version of it? Thanks |
@Basdub https://wzrd.in/standalone/is-my-json-valid@latest (window.isMyJsonValid(...) afterwards) |
Having it work in Browserify & Webpack is already fine for me, but you might want to checkout UMD for this: https://github.com/umdjs/umd |
@sathishk The JSEN issue you've referred to actually represents a badly defined schema, not really a limitation of JSEN. |
Are there any plans to include browser support in this project? IMJV performs far better than the current JSON Schema validators that also work in the browser (Z-Schema and tv4). Using browserify in combination with
worked fine for me, and validating my objects takes 30ms compared to upwards of 3.5s using Z-Schema. I'd hate to think that others are skipping this library and its performance benefits because there isn't a pre-built version for web browsers.
The text was updated successfully, but these errors were encountered: