Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom address attribute shown on frontend #12524

Open
versdivers opened this issue Dec 2, 2017 · 19 comments
Open

Custom address attribute shown on frontend #12524

versdivers opened this issue Dec 2, 2017 · 19 comments
Labels
Area: Account Component: Frontend Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@versdivers
Copy link

I have added a custom attribute to the customer address. Now this should only be visible for the admin and not for the customer.

Preconditions

  1. Magento 2.2.1
  2. PHP 7+

Steps to reproduce

  1. Create a custom attribute programmaticly code
        $eavSetup->removeAttribute('customer_address', 'your_attribute');
        $eavSetup->addAttribute('customer_address', 'your_attribute', array(
            'type' => 'varchar',
            'label' => 'Exact Address ID',
            'input' => 'text',
            'required' => false,
            'unique' => true,
            'system' => 0,
            'global' => ScopedAttributeInterface::SCOPE_WEBSITE,
            'sort_order' => '1'
        ));
        $your_attribute = $this->_attributeRepository->get('customer_address', 'your_attribute ');
        $setup->getConnection()
            ->insertOnDuplicate(
                $setup->getTable('customer_form_attribute'),
                [
                    ['form_code' => 'adminhtml_customer_address', 'attribute_id' => your_attribute ->getId()]
                ]
            );
  1. Fill in the new attribute in a customer
  2. go to checkout

Expected result

  1. Its only added to adminhtml_customer_address so it should not be picked up by the knockout to display on checkout

Actual result

  1. Field is not shown in customer account
  2. Field is shown at checkout

image

image

  1. not shown in checkout 'add new address' (which is good)

And do not even try starting this conversation with 'we can not reproduce your situation. We are here to help you fix your bugs.

Prove that in de DB table it only has adminhtml_customer_address

image
image

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 2, 2017
@magento-engcom-team magento-engcom-team self-assigned this Dec 4, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 4, 2017
@magento-engcom-team magento-engcom-team removed their assignment Dec 4, 2017
@magento-engcom-team
Copy link
Contributor

@versdivers, thank you for your report.
We've created internal ticket(s) MAGETWO-84952 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 4, 2017
@versdivers
Copy link
Author

Just a question but am i getting notified here when there is a fix so i can fix it waiting for an update?

@shyamranpara
Copy link
Contributor

#MM18IN Please assign this issue to me.

@magento-engcom-team
Copy link
Contributor

@shyamranpara thank you for joining. Please accept team invitation here and self-assign the issue.

@versdivers
Copy link
Author

If you need any more information please let me know

@ksiamro
Copy link

ksiamro commented Mar 13, 2018

I have similar issue with Magneto 2.1.7

@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 15, 2018
@Rudoslav
Copy link

I also ran into this issue in 2.2.1.

@thomashery
Copy link

Hi @okobchenko , looking at one of the file part of @shyamranpara pull request, I cannot see any merge in the commit history:
https://github.com/magento/magento2/commits/2.2-develop/app/code/Magento/Checkout/Model/DefaultConfigProvider.php
Can you please clarify if this was actually fixed?

@ghost ghost removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 20, 2020
@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 30, 2020
@engcom-Lima engcom-Lima added Area: Frontend Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Frontend and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 25, 2021
@engcom-Alfa engcom-Alfa added Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 25, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1044 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2021

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 30, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Frontend Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Development
Development

No branches or pull requests