Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin can not make reorder if customer address has image attribute #30294

Closed
magento-engcom-team opened this issue Oct 1, 2020 · 11 comments
Closed
Assignees
Labels
Area: Admin UI CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@magento-engcom-team
Copy link
Contributor

If customer address contains custom attribute of image type admin can not create reorder

Steps to Reproduce:

  1. Login as Admin
  2. Create new custom customer address attribute (Store -> Attributes -> Customer Address):
    #* Type = Image
  3. On Frontend create customer
  4. Add default address (for both shipping and billing) and upload some image to newly created attribute
  5. Make order using newly created default address for both shipping and billing
  6. Login as Admin
  7. Open Orders (Sales -> Orders)
  8. Open newly created order
  9. Click Reorder link
  10. Click Submit Order button

Actual Result:
(-) White page with no errors

Expected Result:
(/) Reorder is created

@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev labels Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-33703

@magento-engcom-team magento-engcom-team added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Oct 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 1, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-33703 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@DipakVadher
Copy link

@magento I am working on it

@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2020

Hi @DipakVadher! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@DipakVadher
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Oct 9, 2020

Hi @DipakVadher! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@DipakVadher
Copy link

@magento I am working on it

@viniciusbordinhao-blueacorn
Copy link
Contributor

@magento I am working on it.

@viniciusbordinhao-blueacorn
Copy link
Contributor

@magento-engcom-team

It is related to issue #30293 , Therefore I will use the same comment that I wrote there:

This issue is not reproducible on Community Edition since the media_image type is banned from the frontend and backend as an attribute like you can see below:

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/Model/Address/DataProvider.php#L216

I am not even able to create the attribute via admin panel like the steps to reproduce the issue suggested. It is not available for CE as well. I think the issue should be reported as an EE issue not like CE.

Please let me know if I have forgotten something regarding it.

@engcom-Bravo
Copy link
Contributor

Hi @magento-engcom-team,

We have tried to reproduce the issue in Latest 2.4-develop with EE edition instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Image

Reorder is created

Hence we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

No branches or pull requests

7 participants