Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyMCE missing font size selector in v7 #39440

Open
1 of 5 tasks
domeglic opened this issue Dec 5, 2024 · 4 comments
Open
1 of 5 tasks

tinyMCE missing font size selector in v7 #39440

domeglic opened this issue Dec 5, 2024 · 4 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p10 Indicates original Magento version for the Issue report.

Comments

@domeglic
Copy link

domeglic commented Dec 5, 2024

Preconditions and environment

  • 2.4.5-p10

Steps to reproduce

  • Open any field with tinyMCE editor activated

Expected result

  • Expect font size selector next to font format (Paragraph, headings)

Actual result

  • Missing font size selector

Additional information

This is because of update from tinyMCE v5 to v7 in the latest security update. In v6 options got renamed: https://www.tiny.cloud/docs/tinymce/6/migration-from-5x/#things-we-renamed

I found two places where this is configured:

It should be fontsize instead of fontsizeselect. Could also have other things that need to be renamed, I just noticed this one.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 5, 2024

Hi @domeglic. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Dec 5, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p10 Indicates original Magento version for the Issue report. label Dec 5, 2024
@PatrickWhitehouse
Copy link

@domeglic there seems to be a patch ACSD-62755 that fixes this issue, however, I have applied this and it doesn't appear to fix it for me on 2.4.5-p10.

@engcom-Bravo
Copy link
Contributor

@PatrickWhitehouse Thanks for your Contribution!!.

Hi @domeglic,

Thanks for your reporting and collaboration.

As per the Magento Release Notes https://experienceleague.adobe.com/en/docs/commerce-operations/tools/quality-patches-tool/release-notes patch ACSD-62755 fixes the font size issue for tinyMCE 7.

Screenshot 2024-12-06 at 10 27 45 am

Could you please refer the document and let us know if you are still facing any issue.

Thanks

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 6, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p10 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

3 participants