Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Extract Identity model from Login #15

Open
marcoow opened this issue Aug 21, 2015 · 3 comments
Open

Extract Identity model from Login #15

marcoow opened this issue Aug 21, 2015 · 3 comments
Assignees
@oliverbarnes
Labels
enhancement

Comments

@marcoow
Copy link
Member

marcoow commented Aug 21, 2015

We should extract the credentials and the Facebook data from the Login model into Identity models and use STI to inherit CredentialsIdentity, FacebookIdentity model (and more in the future) from that. That way the code gets much cleaner and it's also easier to add more identity providers in the future.
@oliverbarnes
Copy link
Contributor

👍 how about adding another identity provider in concrete (Twitter?), to avoid YAGNI?

@marcoow
Copy link
Member Author

marcoow commented Aug 21, 2015

that would be the 2nd step then

@oliverbarnes oliverbarnes self-assigned this Aug 21, 2015
@oliverbarnes
Copy link
Contributor

on it

@oliverbarnes oliverbarnes mentioned this issue Sep 7, 2015
Merged
@marcoow marcoow mentioned this issue Apr 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oliverbarnes oliverbarnes

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoow @oliverbarnes