Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response none when prosody has no text #18

Open
markmacau opened this issue May 18, 2018 · 1 comment
Open

response none when prosody has no text #18

markmacau opened this issue May 18, 2018 · 1 comment

Comments

@markmacau
Copy link

Thanks for great tool. I found that ssml-builder return null when no text such as '' provided for prosody.

This returns ssml properly:
speech.prosody({rate: "110%"},"abc")

This returns null:
speech.prosody({rate: "110%"},"")

Because I use ssml-builder inside for-loop, above situation happened. I solved my problem to check value existence before fire ssml-builder.

I think it is better if there is some error message in such case.

@RokasVaitkevicius
Copy link

There is a test in place testing just that and it passes. It throws an error "The word provided to Speech#prosody(..) was empty". The same happens if you try to add empty word in the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants