Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifted off by a day #4

Open
mappum opened this issue May 17, 2014 · 2 comments
Open

Shifted off by a day #4

mappum opened this issue May 17, 2014 · 2 comments
Labels

Comments

@mappum
Copy link
Owner

mappum commented May 17, 2014

A timezone issue causes some banners to be a day off. Example: https://github.com/replaid

@mappum mappum added the bug label May 17, 2014
@mlsteele
Copy link

I think this has something to do with daylight savings time.

This image is a screenshot of running version 61f6d9f with a slight patch to create commits one day prior. The input was " Doin' Stuff" (with the initial space).

gitbanner-time-bug

Sorry about that image showing three experiments at once. The "D" seems ok but somewhere around March things it gets shifted such that the "u" is shifted one off. Daylight savings is March 9 in the US, so I bet that's related.

@replaid
Copy link

replaid commented May 19, 2014

Thanks for turning this into an issue. Happy to help in any way that's useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants