Run lint for PRs and on commit

Jenkinsfile

@@ -0,0 +1,11 @@
+def config = jobConfig {
+    slackChannel = 'tools-eng'  // TODO: Change this when Viktor provides one
+}
+
+def job = {
+    stage('Lint') {
+        sh 'scripts/lint.sh'
+    }
+}
+
+runJob config, job

scripts/common.sh

@@ -0,0 +1,11 @@
+if [ -t 1 ] ; then
+  RED='\033[0;31m'
+  GREEN='\033[0;32m'
+  BLUE='\033[0;34m'
+  RS='\033[0m' # reset to no color
+else
+  RED=''
+  GREEN=''
+  BLUE=''
+  RS=''
+fi

scripts/lint.sh

@@ -1,8 +1,6 @@
 #!/bin/bash
-error=0
-RED='\033[0;31m'
-RS='\033[0m' # No Color
-GREEN='\033[0;32m'
+
+. scripts/common.sh
 
 echo -e "==> ${GREEN}Linting cp-helm-charts..${RS}."
 
@@ -18,5 +16,3 @@ for chart in `ls -1 charts`; do
   echo -e "$output" | grep "\\["
 done
 echo -e "==> ${GREEN} No linting errors${RS}"
-
-exit $error

scripts/package.sh

@@ -1,8 +1,6 @@
 #!/usr/bin/env bash
-RED='\033[0;31m'
-GREEN='\033[0;32m'
-BLUE='\033[0;34m'
-RS='\033[0m' # reset
+
+. scripts/common.sh
 
 echo -e "${RS}${BLUE} Cleaning and preparing..."
 find . -iname "*.tgz" -type f | grep -v 'docs/' | xargs rm
@@ -27,4 +25,4 @@ if [[ "${RET}" == 0 ]]; then
     echo -e "${BLUE} Now commit and push charts and docs! ${RS}"
 else
     echo -e "${RED}Tests failed, charts not packaged! ${RS}"
-fi
+fi