From 60d34b68f4c42da04dd0a064db135568c5d75af9 Mon Sep 17 00:00:00 2001 From: Abhishek Chennaka Date: Mon, 6 Dec 2021 17:43:13 -0500 Subject: [PATCH] [KUDU-1959] - Fix the counter in StartupProgressStepsRemainingMetric() The counter was incremented twice if tablets are not processed during the startup of a tablet server. This is a follow-up to 59070bf. Change-Id: I6570f438dd85aafa16093465ae654ece8d056eb5 Reviewed-on: http://gerrit.cloudera.org:8080/18073 Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- src/kudu/server/startup_path_handler.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/kudu/server/startup_path_handler.cc b/src/kudu/server/startup_path_handler.cc index 6e1948f10e..e059c1f982 100644 --- a/src/kudu/server/startup_path_handler.cc +++ b/src/kudu/server/startup_path_handler.cc @@ -141,7 +141,6 @@ int StartupPathHandler::StartupProgressStepsRemainingMetric() { int counter = 0; counter += (init_progress_.IsStopped() ? 0 : 1); counter += (read_filesystem_progress_.IsStopped() ? 0 : 1); - counter += (is_tablet_server_ ? (start_tablets_progress_.IsStopped() ? 0 : 1) : 0); if (is_tablet_server_) { counter += start_tablets_progress_.IsStopped() ? 0 : 1; } else {