Skip to content

Commit

Permalink
version: Only let git describe match tags beginning with a digit.
Browse files Browse the repository at this point in the history
This will let us use other tags for things like `@zulip/shared`
versions.

Signed-off-by: Anders Kaseorg <[email protected]>
  • Loading branch information
andersk authored and timabbott committed Oct 24, 2019
1 parent 99d34e6 commit 453919b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/cache-zulip-git-version
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
set -e

cd "$(dirname "$0")/.."
git describe --tags > zulip-git-version || true
git describe --tags --match='[0-9]*' > zulip-git-version || true
2 changes: 1 addition & 1 deletion zerver/logging_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
def try_git_describe() -> Optional[str]:
try: # nocoverage
return subprocess.check_output(
['git', 'describe', '--tags', '--always', '--dirty', '--long'],
['git', 'describe', '--tags', '--match=[0-9]*', '--always', '--dirty', '--long'],
stderr=subprocess.PIPE,
cwd=os.path.join(os.path.dirname(__file__), '..'),
).strip().decode('utf-8')
Expand Down

0 comments on commit 453919b

Please sign in to comment.