From cb90c89de14aab636739b3e810cf949e47b54a0c Mon Sep 17 00:00:00 2001 From: Pablo Galindo Date: Tue, 19 Mar 2019 17:17:58 +0000 Subject: [PATCH] bpo-36367: Free buffer if realloc fails in tokenize.c (GH-12442) --- Parser/tokenizer.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Parser/tokenizer.c b/Parser/tokenizer.c index 8f0a9c810053a9..ad054975689ee1 100644 --- a/Parser/tokenizer.c +++ b/Parser/tokenizer.c @@ -649,9 +649,14 @@ translate_newlines(const char *s, int exec_input, struct tok_state *tok) { } *current = '\0'; final_length = current - buf + 1; - if (final_length < needed_length && final_length) + if (final_length < needed_length && final_length) { /* should never fail */ - buf = PyMem_REALLOC(buf, final_length); + char* result = PyMem_REALLOC(buf, final_length); + if (result == NULL) { + PyMem_FREE(buf); + } + buf = result; + } return buf; } @@ -958,6 +963,7 @@ tok_nextc(struct tok_state *tok) newbuf = (char *)PyMem_REALLOC(newbuf, newsize); if (newbuf == NULL) { + PyMem_FREE(tok->buf); tok->done = E_NOMEM; tok->cur = tok->inp; return EOF;