Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The "Language Icons Coloured" slider option does not change anything (icon always appears with color) #261

Open
mikkelens opened this issue May 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mikkelens
Copy link

mikkelens commented May 6, 2024

Describe the bug

It does not render the icon in black/white like the description claims it should.
I could not find any other issue mentioning this problem, though I merely searched for the option name and similar.

Steps to reproduce

Enable icons and headers to see the icon on your code block. Turn off Language Icons Coloured in settings under Codeblock Styling->Codeblock Header->Header Language Icon Appearance
View

```rust title:main.rs
fn main() {
    println!();
}
```

Also tested with the default python example code (issue persists there too).

Expected behaviour

The icon renders in black/white like the description claims. I assume this is supposed to mean that the icon sources a different language icon file, or just black/white filters it?

Current behaviour

It renders with colors like it should only when the problematic option is turned on.

Environment

  • Plugin Version: latest/1.1.7
  • Obsidian Version: latest/v1.5.12
  • Platform: Desktop
  • OS: Windows 10
  • Theme: Obsidian's default and "Default" selected in plugin's Theme Settings
  • CSS Snippets: None
  • Other notes: I have a decent amount of plugins, though not many that overhaul the visuals too much.

Screenshots

image

Additional context

No errors or weird behaviour, other than it's sometimes unclear when changing settings actually affects the shown example within the settings area. The problem persists outside this area though.

@mikkelens mikkelens added the bug Something isn't working label May 6, 2024
@mikkelens mikkelens changed the title Bug: The "Language Icons Coloured" setting/slider does nothing when turned off Bug: The "Language Icons Coloured" slider option does not change anything (icon always appears with color) May 6, 2024
@mayurankv
Copy link
Owner

Urgh, will test this! Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants