Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Gaps in codeblock #282

Open
ReedSmith7 opened this issue Sep 5, 2024 · 3 comments
Open

Bug: Gaps in codeblock #282

ReedSmith7 opened this issue Sep 5, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ReedSmith7
Copy link

ReedSmith7 commented Sep 5, 2024

Describe the bug

When creating a codeblock, there are gaps that cannot be removed. I have provided screenshots of what this looks like. Please explain what needs to be done differently.

Screenshots

image
image

No matter whether I include a title, language, anything, the gaps remain.

Additional context

@ReedSmith7 ReedSmith7 added the bug Something isn't working label Sep 5, 2024
@mayurankv
Copy link
Owner

Sorry where are the gaps? Above line 1 and below line 3 in editing mode? They shouldn't exist in reading mode. If so, there's not much I can do about that since in editing mode the lines where the backticks appear (as in your second image) must exist.

There's a couple of things I could do:

  1. Make the line height for those backtick lines smaller to be less prominent
  2. Hide those lines when not inside the code block completely

I don't really like the first option but I'll definitely consider the second!

@ReedSmith7
Copy link
Author

Above line 1 and below line 3. They unfortunately do exist in reading mode. I agree the first option wouldn’t help, so if you can get around to the second option that would be great! For the most part it is a non-issue however, so thank you for your response!

@mayurankv
Copy link
Owner

No worries! I'll actively try and add the second option (maybe after the refactor release though). I'm literally working on the reading view css right now and In the refactor there won't be any such gap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants