Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL option doesn't reflect the right options #846

Open
1 task done
antonymilne opened this issue Oct 31, 2024 · 0 comments
Open
1 task done

ALL option doesn't reflect the right options #846

antonymilne opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
Bug Report 🐛 Issue contains a bug report

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Oct 31, 2024

Which package?

vizro

Package version

0.1.26

Description

Not sure whether it's worth fixing now or waiting until we have the new and improved "tick all" functionality though. It's kind of a big bug but the fact that no one spotted it yet shows it can't be that important...

There's already an obvious problem with the ALL option working "dynamically" like it does now: when you manually set options then I would expect ALL to mean "all the options you specified" but actually it means "all the options in the data".

I don't know why we didn't realise this before because it's pretty obvious in hindsight 🤔 I guess this shows that no one really manually specifies options for a vm.Filter, which is useful to know anyway.

How to Reproduce

PyCafe link

Output

No response

Code of Conduct

@antonymilne antonymilne added the Bug Report 🐛 Issue contains a bug report label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report 🐛 Issue contains a bug report
Projects
None yet
Development

No branches or pull requests

2 participants