Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the precision of some datetime attributes #128

Open
daronco opened this issue Jun 16, 2016 · 3 comments
Open

Increase the precision of some datetime attributes #128

daronco opened this issue Jun 16, 2016 · 3 comments
Assignees
Milestone

Comments

@daronco
Copy link
Member

daronco commented Jun 16, 2016

Some of the dates returned by the web conference server are being stored in the database as a datetime, even though they are returned as a timestamp (with 13 digits).
Some other dates are already being stored with a higher precision, as for example t.decimal :create_time, precision: 14, scale: 0.

The following dates should also be stored as decimal to increase their precision:

  • BigbluebuttonRecording#start_time
  • BigbluebuttonRecording#end_time
  • BigbluebuttonMeeting#create_time
@daronco daronco added this to the v2.1.0 milestone Jun 16, 2016
@daronco daronco modified the milestones: v2.1.0, v2.2.0 Jul 22, 2016
@daronco
Copy link
Member Author

daronco commented Sep 2, 2016

See #106.

@daronco
Copy link
Member Author

daronco commented Feb 8, 2017

Implemented in the branch v3-gem, currently being tested with mconf/mconf-web@v3.

@daronco
Copy link
Member Author

daronco commented Jun 1, 2017

One thing I noticed is that some values are being stored with 10 digits while others have 13. This is probably because Rails works with 10-digit numbers when using to_i and Time.at(), but the numbers returned by the API have 13 digits.

If all timestamps in the API have 13 digits, they should have 13 digits in the database as well. This needs to be reviewed and adapted somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants