Fix race in nat traversal (ava-labs#2285)

mdr0id · Nov 25, 2022 · b450f46 · b450f46
1 parent 1437bfe
commit b450f46
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/nat/nat.go b/nat/nat.go
@@ -83,6 +83,7 @@ func (m *Mapper) Map(protocol string, intPort, extPort uint16, desc string, ip i
 		)
 	}
 
+	m.wg.Add(1)
 	go m.keepPortMapping(protocol, intPort, extPort, desc, ip, updateTime)
 }
 
@@ -112,8 +113,6 @@ func (m *Mapper) retryMapPort(protocol string, intPort, extPort uint16, desc str
 func (m *Mapper) keepPortMapping(protocol string, intPort, extPort uint16, desc string, ip ips.DynamicIPPort, updateTime time.Duration) {
 	updateTimer := time.NewTimer(updateTime)
 
-	m.wg.Add(1)
-
 	defer func(extPort uint16) {
 		updateTimer.Stop()